fix: close ship-blocking gaps and reconcile stale gap docs for v1#120
Merged
Conversation
WS-D — Mail DKIM: publish the real generated public key in the _dkim._domainkey TXT record instead of the literal "p=<public_key>" placeholder; add MailHandler._dkim_txt_value plus a regression test. WS-E — Operational hardening: raise pgmq-unavailable admission-consumer logs from info to WARNING across phase_ands/phase_inworld_identity/ phase_services, and surface an "events" block (enabled + reason) in the operator API /health endpoint via a best-effort pgmq_available() probe. WS-F — Docs/claims hygiene: correct the README cross-world federation roadmap item (DNS-stub peering prototyped; full routing/resolution still gated), prepend dated status corrections to GAP_SUMMARY.txt and COMPREHENSIVE_GAP_ANALYSIS.md (several items already resolved), and add a test enforcing every feature_state registry entry is documented in the alpha support matrix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NsdPH4dcsbTWeTFuTgswY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation fixes toward a v1/production release — the low-risk, high-value "honesty + safety" batch. Three independent workstreams:
WS-D — Mail DKIM
The
_dkim._domainkeyTXT record published a literalv=DKIM1; k=rsa; p=<public_key>placeholder ("Simplified for MVP"), so DKIM signatures could never validate. NowMailHandler._dkim_txt_valuederives the realp=base64 DER from the generated public key and threads it into_inject_dns_records. Added a regression test guarding against the placeholder.WS-E — Operational hardening
pgmq-unavailable previously disabled admission-event consumers silently at
infolevel — operators couldn't tell event-driven provisioning was off. Now:phase_ands,phase_inworld_identity,phase_services) log at WARNING with an actionable message.GET /api/v1/healthsurfaces aneventsblock (enabled+ reason) via a best-effortpgmq_available()probe incore/db_client.WS-F — Docs & claims hygiene
unsupported.docs/GAP_SUMMARY.txtanddocs/COMPREHENSIVE_GAP_ANALYSIS.md(a code re-audit found several listed gaps already resolved: all four operator API mutation endpoints exist, SPF/DMARC are wired, reload persists the spec, Phase 9 prereq present).feature_stateregistry entry is documented indocs/spec-alpha-support.md.Testing
pytest tests/ -q): all passing, no new failures.black/isort/flake8;core/db_client.pypassesmypy --strict.🤖 Generated with Claude Code
Generated by Claude Code