Promote CLI override parsing to config loader#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--setdottedkey=valueoverride parsing into a reusable config helper so other code can reuse the logic and keep parsing behavior consistent.key=value, reject empty dotted path components, parse values with YAML semantics, and disallow nesting under scalar values.Description
ConfigOverrideErrorandparse_dotted_overrides(values: Iterable[str]) -> dict[str, Any]tonetengine/config/loader.py, implementing YAMLsafe_loadvalue parsing, empty-part validation, and scalar-vs-object conflict detection.netengine/cli/main.pywith a small shim_parse_set_overridesthat delegates toparse_dotted_overridesand convertsConfigOverrideErrorintoclick.BadParameterwith the--sethint.tests/test_config.py(TestParseDottedOverrides) covering nested overrides, YAML scalar/list parsing, malformed inputs, and scalar/nested conflicts.Testing
python -m ruff check netengine/config/loader.py netengine/cli/main.py tests/test_config.pywhich passed.pytest tests/test_config.py tests/test_cli.py -q, which succeeded (all tests passed: 64 passed).Codex Task