Explicit ${env:VAR} interpolation support in ConfigLoader#159
Merged
aidankhogg merged 1 commit intoJun 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
${env:VAR}alias while retaining OmegaConf's built-in${oc.env:VAR}syntax.Description
_get_required_env_varhelper andregister_env_resolver()that registers a custom OmegaConf resolver for the${env:VAR}alias and call it at package init and before resolving configs.register_env_resolver()fromConfigLoader.load_configandConfigLoader.resolve_env_vars, and update their docstrings to document supported syntaxes (${env:VAR}and${oc.env:VAR}) and missing-variable behavior.tests/test_config.pythat verify${env:VAR}resolution,${oc.env:VAR}compatibility, failure on missing variables, andresolve_env_varsbehavior using temporary environment variables.blackon the changed files.Testing
pytest tests/test_config.py -qand all tests in that file passed (51 passed).python -m black --check netengine/config/loader.py tests/test_config.pywhich succeeded (files formatted where necessary).python -m mypy netengine --strictwhich reported pre-existing typing issues in unrelated files (these failures are not introduced by this change).Codex Task