perf(mcp-server): trigger workflow by id instead of listing all workflows (PRD-831)

[christophebrun-forest]

Summary

Optimization from the PRD-49 review (stacked on #1792). triggerWorkflow used
to call listMcpWorkflows without filter before every trigger, then do a
client-side find, only to resolve the workflow name + collectionName
needed for the activity-log label. That added a useless HTTP round-trip per
trigger, duplicated the server's own validation, and would produce false
negatives if the listing ever got paginated.

Change

• Trigger directly by id — the pre-listMcpWorkflows call and client-side
  find (and the PRD-831 comment) are gone.
• Label from the start response. The server enriches its 202 to
  { runId, runState, workflowName, collectionName }; the tool builds the audit
  label from those. When an older server omits them, it falls back to the
  workflowId — deploys are order-independent, label enrichment simply lights
  up once the server ships.
• 404 → same error. An unknown / MCP-disabled workflow (server 404) is
  mapped back to the existing "is not an MCP-enabled workflow" message, so the
  LLM-facing contract is unchanged.
• Output unchanged — still { runId, runState } only.

Behavior note (reviewers)

The audit log is now written after the run starts (the collection is only
known from the response) and is best-effort: since the run is already
ongoing, an audit hiccup logs a warning instead of failing the tool. As a
consequence, failed triggers (404/409) are no longer audited — consistent with
the server dropping resource-less MCP logs, and with the pre-existing behavior
that unknown-workflow rejections weren't audited.

Tests

trigger-workflow tests reworked: direct-start happy path with the enriched
response, 404 → tool-error mapping, 409 passthrough, the workflowId fallback
when name/collection are absent, and that a failed audit-log write still
returns the run.

Merge order

Do not merge before the forestadmin-server PRD-831 PR (the fallback makes
deploy order safe, but the label only enriches once the server ships).

fixes PRD-831

🤖 Generated with Claude Code

Note

Trigger MCP workflow by ID directly instead of listing all workflows first

• Removes the pre-listing round-trip in declareTriggerWorkflowTool (trigger-workflow.ts); the tool now calls triggerWorkflow directly using the workflow ID.
• After a successful trigger, creates a pending activity log using workflowName/collectionName echoed from the server response, falling back to the workflowId as label.
• Activity log failures are caught and logged as warnings without failing the tool invocation.
• Adds workflowName and collectionName as optional fields to WorkflowRunTriggerResult (types.ts) and passes them through in ForestHttpApi.triggerMcpWorkflow.
• Server 404 responses are mapped to a specific 'not an MCP-enabled workflow you can access' error message; other errors are rethrown as-is.

^{Macroscope summarized c64fc5e.}

[linear-code]

PRD-831

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (2)

Rating	File	% Diff	Uncovered Line #s
	packages/mcp-server/src/tools/trigger-workflow.ts	100.0%
	packages/forestadmin-client/src/permissions/forest-http-api.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.