feat(smart actions): endpoint that handle forms' load hooks

[rap2hpoutre]

Developer' agents have an endpoint that handle smart actions forms' load hooks

• The routes verb is POST
• The routes path is: actions/smart-action-endpoint/hooks/load (or the smart action endpoint)
• The routes handles parameters from request
  • It should transform a recordId to a record.
  • It should get fields from request or get it from schema when missing (we could discuss about it later).
• The routes sends fields and record to the callback (the function defined by the user).
• The route has to consider the return value from the callback then trigger error in UI with 500 code and console when something went wrong, e.g:
  • Error has been thrown in the function
  • Nothing is returned
  • load is not a function
  • a field is deleted or added (new key or missing key in fields)
  • Add a test for each error case
• Add a test for valid case

Almost all lines of code are covered (90.3%, not sure why it's not 100%).

I suggest reviewing code by opening src/routes/actions.js rather than reading the diff.

Pull Request checklist:

• Write an explicit title for the Pull Request, following Conventional Commits specification
• Test manually the implemented changes (not that simple, I will do this during review)
• Review my own code (indentation, syntax, style, simplicity, readability)
• Wonder if you can improve the existing code

Tests

routes > actions
  ✓ should not create a route when no actions is present (3ms)
  ✓ should not create a route when actions.values or actions.hooks.* are missing present (1ms)
  when actions.values is present
    ✓ should create a route (1ms)
    ✓ should create a valid route callback (1ms)
    ✓ should handle async values function (1ms)
  when action.hooks is present
    when action.hooks.load is present
      ✓ should create a route
      when calling the route controller
        when action.hooks.load is invalid
          ✓ should fail with message when action.hooks.load is not a function (2ms)
          ✓ should fail with message when action.hooks.load does not return an object (2ms)
          ✓ should fail with message when action.hooks.load returned fields are not consistent
        when action.hooks.load is valid
          ✓ should respond success with the updated fields

[forest-bot]

Task linked: CU-a6yc11 Developer' agents have an endpoint that handle smart actions forms' load hooks

[GuillaumeCisco]

Thank you for your work! 🔥
Great thing we can go further in this topic.

I added some possible improvements and some questions.

[GuillaumeCisco]

With this refacto, code is far more easier to read.
I've added some improvements.
Especially in term of complexity.

I'm available for talking about it :)

[qlty-cloud-legacy]

Function isSameDataStructure has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

[GuillaumeCisco]

LGTM 🚀

I will check if we can get rid of the codeclimate warning.
seems overkill to me.

[qlty-cloud-legacy]

Code Climate has analyzed commit 689bb60 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 95.8% (49% is the threshold).

This pull request will bring the total coverage in the repository to 50.9% (0.6% change).

View more on Code Climate.

[GuillaumeCisco]

LGTM ✨

[forest-bot]

🎉 This PR is included in version 7.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[forest-bot]

🎉 This PR is included in version 8.0.0-beta.4 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀