Skip to content

feat(smart actions): endpoint that handle forms' load hooks#565

Merged
rap2hpoutre merged 3 commits intomasterfrom
feat-change-hook
Nov 30, 2020
Merged

feat(smart actions): endpoint that handle forms' load hooks#565
rap2hpoutre merged 3 commits intomasterfrom
feat-change-hook

Conversation

@rap2hpoutre
Copy link
Contributor

@rap2hpoutre rap2hpoutre commented Nov 27, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@forest-bot
Copy link
Member

Copy link
Contributor

@GuillaumeCisco GuillaumeCisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

Everything seems good!
Very nice work!
Clean and concise ✨

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b715215 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (49% is the threshold).

This pull request will bring the total coverage in the repository to 51.1%.

View more on Code Climate.

Copy link
Contributor

@GuillaumeCisco GuillaumeCisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐼

@rap2hpoutre rap2hpoutre merged commit 824a670 into master Nov 30, 2020
@rap2hpoutre rap2hpoutre deleted the feat-change-hook branch November 30, 2020 09:50
forest-bot added a commit that referenced this pull request Nov 30, 2020
# [7.8.0](v7.7.2...v7.8.0) (2020-11-30)

### Features

* **smart actions:** endpoint that handle forms' load hooks ([#565](#565)) ([824a670](824a670))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 2, 2020
# [8.0.0-beta.4](v8.0.0-beta.3...v8.0.0-beta.4) (2020-12-02)

### Bug Fixes

* **schema:** do not generate `framework`, `framework_version` to ensure equality across environments ([#556](#556)) ([30ee17a](30ee17a))
* **smart fields:** compute properly smart fields ([#570](#570)) ([923c968](923c968))
* **smart-actions:** transform legacy widgets in hooks ([#571](#571)) ([f58b867](f58b867))
* **technical:** remove useless data property from load hook controller ([#562](#562)) ([7465982](7465982))

### Features

* **smart actions:** endpoint that handle forms' load hooks ([#546](#546)) ([3e3c018](3e3c018))
* **smart actions:** endpoint that handle forms' load hooks ([#565](#565)) ([824a670](824a670))

### Reverts

* **related-data:** use same reference on record for dataValues and direct attributes ([#569](#569)) ([5e7a689](5e7a689))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
# [7.0.0-beta.10](ForestAdmin/forest-express-sequelize@v7.0.0-beta.9...v7.0.0-beta.10) (2021-02-09)

### Bug Fixes

* array display with smart field ([#575](ForestAdmin/forest-express-sequelize#575)) ([e0698d3](ForestAdmin/forest-express-sequelize@e0698d3))
* correctly set fields holding  belongsTo relationships to null when updated with a null value ([#607](ForestAdmin/forest-express-sequelize#607)) ([374151f](ForestAdmin/forest-express-sequelize@374151f))
* display correct reference field when it is a smartfield ([#584](ForestAdmin/forest-express-sequelize#584)) ([50aef31](ForestAdmin/forest-express-sequelize@50aef31))
* fix belongsTo relationships creation when creating a record ([#602](ForestAdmin/forest-express-sequelize#602)) ([e06dbc8](ForestAdmin/forest-express-sequelize@e06dbc8))
* fix related data list display ([#578](ForestAdmin/forest-express-sequelize#578)) ([370dba7](ForestAdmin/forest-express-sequelize@370dba7))
* fix unconventional pk when referenced as null on creation ([#608](ForestAdmin/forest-express-sequelize#608)) ([af70d62](ForestAdmin/forest-express-sequelize@af70d62))
* handle foreign key toward non primary key ([#585](ForestAdmin/forest-express-sequelize#585)) ([64c78c7](ForestAdmin/forest-express-sequelize@64c78c7))
* secure sql queries generated by leaderboard stats ([#611](ForestAdmin/forest-express-sequelize#611)) ([f41d79c](ForestAdmin/forest-express-sequelize@f41d79c))
* **forestadmin-schema:** regenerate forestadmin schema only when files are valid ([#597](ForestAdmin/forest-express-sequelize#597)) ([a24abbd](ForestAdmin/forest-express-sequelize@a24abbd))
* **leaderboard:** fix an error when use "user" table ([#565](ForestAdmin/forest-express-sequelize#565)) ([0cbbc32](ForestAdmin/forest-express-sequelize@0cbbc32))
* **smart-action-hook:** value injected to an enum field of type  is now correctly handled ([#600](ForestAdmin/forest-express-sequelize#600)) ([c0a3b58](ForestAdmin/forest-express-sequelize@c0a3b58))

### Features

* **filter:** add possibility to filter on smart field ([eaead56](ForestAdmin/forest-express-sequelize@eaead56))
* **filter:** add possibility to filter on smart field ([#583](ForestAdmin/forest-express-sequelize#583)) ([dbf136a](ForestAdmin/forest-express-sequelize@dbf136a))
* **smart actions:** introduce smart action forms hooks ([#569](ForestAdmin/forest-express-sequelize#569)) ([cd13029](ForestAdmin/forest-express-sequelize@cd13029))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments