Skip to content

feat(role-permissions): support the new role ACL format#577

Merged
adriguy merged 3 commits intomasterfrom
feat/roles#07/support-new-ACL-roles-permissions
Dec 8, 2020
Merged

feat(role-permissions): support the new role ACL format#577
adriguy merged 3 commits intomasterfrom
feat/roles#07/support-new-ACL-roles-permissions

Conversation

@adriguy
Copy link
Contributor

@adriguy adriguy commented Dec 4, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5907 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6288 lines exceeds the maximum allowed for the inline comments feature.

@adriguy adriguy requested a review from larcin December 8, 2020 09:19
@adriguy adriguy force-pushed the feat/roles#07/support-new-ACL-roles-permissions branch from 48cf81d to b5d8ef2 Compare December 8, 2020 10:05
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6313 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b5d8ef2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 89.5% (56% is the threshold).

This pull request will bring the total coverage in the repository to 51.7%.

View more on Code Climate.

@adriguy adriguy assigned adriguy and unassigned larcin Dec 8, 2020
@adriguy adriguy merged commit 4aed30f into master Dec 8, 2020
@adriguy adriguy deleted the feat/roles#07/support-new-ACL-roles-permissions branch December 8, 2020 10:11
forest-bot added a commit that referenced this pull request Dec 8, 2020
# [7.9.0](v7.8.9...v7.9.0) (2020-12-08)

### Features

* **role-permissions:** support the new role ACL format ([#577](#577)) ([4aed30f](4aed30f))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 8, 2020
# [8.0.0-beta.5](v8.0.0-beta.4...v8.0.0-beta.5) (2020-12-08)

### Bug Fixes

* **related-data:** use same reference on record for dataValues and direct attributes ([#574](#574)) ([c65588e](c65588e))
* **smart-action:** do not mutate hooks on schema generation ([#580](#580)) ([dd2aee3](dd2aee3))
* **smart-action:** widgetEdit should not be erased when change hook is triggered ([#579](#579)) ([1014ade](1014ade))
* **smart-actions:** error message details missing for hooks ([#582](#582)) ([d2edf35](d2edf35))
* **smart-actions:** reset value when not present in enums in hook response ([#584](#584)) ([0f57a46](0f57a46))
* **smart-actions:** use changedField instead of comparing values to trigger the correct change hook ([#583](#583)) ([54d536b](54d536b))
* record not found in hooks (recordsId replaced with recordIds) ([#578](#578)) ([ccf6a8f](ccf6a8f))

### Features

* **role-permissions:** support the new role ACL format ([#577](#577)) ([4aed30f](4aed30f))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments