fix(smart-actions): reset value when not present in enums in hook response#584
Merged
rap2hpoutre merged 2 commits intomasterfrom Dec 7, 2020
Merged
fix(smart-actions): reset value when not present in enums in hook response#584rap2hpoutre merged 2 commits intomasterfrom
rap2hpoutre merged 2 commits intomasterfrom
Conversation
|
Code Climate has analyzed commit 650e4be and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (56% is the threshold). This pull request will bring the total coverage in the repository to 51.4%. View more on Code Climate. |
GuillaumeCisco
approved these changes
Dec 7, 2020
Contributor
GuillaumeCisco
left a comment
GuillaumeCisco
left a comment
There was a problem hiding this comment.
Everything is alright to me 👍
forest-bot
added a commit
that referenced
this pull request
Dec 7, 2020
## [7.8.8](v7.8.7...v7.8.8) (2020-12-07) ### Bug Fixes * **smart-actions:** reset value when not present in enums in hook response ([#584](#584)) ([0f57a46](0f57a46))
Member
|
🎉 This PR is included in version 7.8.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Dec 8, 2020
# [8.0.0-beta.5](v8.0.0-beta.4...v8.0.0-beta.5) (2020-12-08) ### Bug Fixes * **related-data:** use same reference on record for dataValues and direct attributes ([#574](#574)) ([c65588e](c65588e)) * **smart-action:** do not mutate hooks on schema generation ([#580](#580)) ([dd2aee3](dd2aee3)) * **smart-action:** widgetEdit should not be erased when change hook is triggered ([#579](#579)) ([1014ade](1014ade)) * **smart-actions:** error message details missing for hooks ([#582](#582)) ([d2edf35](d2edf35)) * **smart-actions:** reset value when not present in enums in hook response ([#584](#584)) ([0f57a46](0f57a46)) * **smart-actions:** use changedField instead of comparing values to trigger the correct change hook ([#583](#583)) ([54d536b](54d536b)) * record not found in hooks (recordsId replaced with recordIds) ([#578](#578)) ([ccf6a8f](ccf6a8f)) ### Features * **role-permissions:** support the new role ACL format ([#577](#577)) ([4aed30f](4aed30f))
Member
|
🎉 This PR is included in version 8.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
## [6.6.3](ForestAdmin/forest-express-sequelize@v6.6.2...v6.6.3) (2020-12-21) ### Bug Fixes * display correct reference field when it is a smartfield ([#584](ForestAdmin/forest-express-sequelize#584)) ([50aef31](ForestAdmin/forest-express-sequelize@50aef31))
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
# [7.0.0-beta.10](ForestAdmin/forest-express-sequelize@v7.0.0-beta.9...v7.0.0-beta.10) (2021-02-09) ### Bug Fixes * array display with smart field ([#575](ForestAdmin/forest-express-sequelize#575)) ([e0698d3](ForestAdmin/forest-express-sequelize@e0698d3)) * correctly set fields holding belongsTo relationships to null when updated with a null value ([#607](ForestAdmin/forest-express-sequelize#607)) ([374151f](ForestAdmin/forest-express-sequelize@374151f)) * display correct reference field when it is a smartfield ([#584](ForestAdmin/forest-express-sequelize#584)) ([50aef31](ForestAdmin/forest-express-sequelize@50aef31)) * fix belongsTo relationships creation when creating a record ([#602](ForestAdmin/forest-express-sequelize#602)) ([e06dbc8](ForestAdmin/forest-express-sequelize@e06dbc8)) * fix related data list display ([#578](ForestAdmin/forest-express-sequelize#578)) ([370dba7](ForestAdmin/forest-express-sequelize@370dba7)) * fix unconventional pk when referenced as null on creation ([#608](ForestAdmin/forest-express-sequelize#608)) ([af70d62](ForestAdmin/forest-express-sequelize@af70d62)) * handle foreign key toward non primary key ([#585](ForestAdmin/forest-express-sequelize#585)) ([64c78c7](ForestAdmin/forest-express-sequelize@64c78c7)) * secure sql queries generated by leaderboard stats ([#611](ForestAdmin/forest-express-sequelize#611)) ([f41d79c](ForestAdmin/forest-express-sequelize@f41d79c)) * **forestadmin-schema:** regenerate forestadmin schema only when files are valid ([#597](ForestAdmin/forest-express-sequelize#597)) ([a24abbd](ForestAdmin/forest-express-sequelize@a24abbd)) * **leaderboard:** fix an error when use "user" table ([#565](ForestAdmin/forest-express-sequelize#565)) ([0cbbc32](ForestAdmin/forest-express-sequelize@0cbbc32)) * **smart-action-hook:** value injected to an enum field of type is now correctly handled ([#600](ForestAdmin/forest-express-sequelize#600)) ([c0a3b58](ForestAdmin/forest-express-sequelize@c0a3b58)) ### Features * **filter:** add possibility to filter on smart field ([eaead56](ForestAdmin/forest-express-sequelize@eaead56)) * **filter:** add possibility to filter on smart field ([#583](ForestAdmin/forest-express-sequelize#583)) ([dbf136a](ForestAdmin/forest-express-sequelize@dbf136a)) * **smart actions:** introduce smart action forms hooks ([#569](ForestAdmin/forest-express-sequelize#569)) ([cd13029](ForestAdmin/forest-express-sequelize@cd13029))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: