Skip to content

Conversation

@ryanbas21
Copy link
Contributor

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4564

https://pingidentity.atlassian.net/browse/SDKS-4565

https://pingidentity.atlassian.net/browse/SDKS-4566

Description

Fixes the webauthn type ParsedCredentials. This caused a type check failure because of updates in Node types.

Working on fixing the release issues

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: db5c441

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@forgerock/javascript-sdk Patch
@forgerock/ping-protect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2025

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit db5c441

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-25 20:51:11 UTC

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.93%. Comparing base (f9d571b) to head (db5c441).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/javascript-sdk/src/fr-webauthn/interfaces.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #565   +/-   ##
========================================
  Coverage    56.93%   56.93%           
========================================
  Files          105      105           
  Lines        31600    31600           
  Branches      1785     1785           
========================================
  Hits         17991    17991           
  Misses       13609    13609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"homepage": "https://github.com/ForgeRock/forgerock-javascript-sdk#readme",
"devDependencies": {
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw you removed browserstack and nx-cloud. Should we update this to version not at risk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we aren't using browserstack and nx cloud shouldn't be a dependency anymore.

@github-actions github-actions bot added the NX label Nov 25, 2025
@ryanbas21 ryanbas21 merged commit ac5eab1 into develop Nov 25, 2025
3 checks passed
@ryanbas21 ryanbas21 mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants