-
Notifications
You must be signed in to change notification settings - Fork 47
fix: webauthn-parsed-credentials-type #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: db5c441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t build lint test docs e2e-ci |
✅ Succeeded | <1s | View ↗ |
nx-cloud record -- nx format:check --verbose |
✅ Succeeded | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-25 20:51:11 UTC
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #565 +/- ##
========================================
Coverage 56.93% 56.93%
========================================
Files 105 105
Lines 31600 31600
Branches 1785 1785
========================================
Hits 17991 17991
Misses 13609 13609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
549eff8 to
80c5286
Compare
| "homepage": "https://github.com/ForgeRock/forgerock-javascript-sdk#readme", | ||
| "devDependencies": { | ||
| "@changesets/changelog-github": "^0.5.0", | ||
| "@changesets/cli": "^2.27.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw you removed browserstack and nx-cloud. Should we update this to version not at risk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we aren't using browserstack and nx cloud shouldn't be a dependency anymore.
80c5286 to
5b7390b
Compare
5b7390b to
db5c441
Compare

JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4564
https://pingidentity.atlassian.net/browse/SDKS-4565
https://pingidentity.atlassian.net/browse/SDKS-4566
Description
Fixes the webauthn type
ParsedCredentials. This caused a type check failure because of updates in Node types.Working on fixing the release issues