This repository was archived by the owner on Aug 19, 2022. It is now read-only.
Better support for old and tweener flexbox syntax #279
Merged
ianobermiller merged 3 commits intoFormidableLabs:masterfrom Jul 24, 2015
Merged
Better support for old and tweener flexbox syntax #279ianobermiller merged 3 commits intoFormidableLabs:masterfrom
ianobermiller merged 3 commits intoFormidableLabs:masterfrom
Conversation
modules/prefixer.js
Outdated
Contributor
There was a problem hiding this comment.
nit: sort this list alphabetically, and remove spaces inside the braces
Contributor
|
Awesome work, thank you! Just a little clean up and this will be good to merge. I've also fixed the error on master so travis should be passing. |
Contributor
Author
|
Cleaned up the code. Also I've not mentioned that it's not tested on old webkit, although on Firefox 19 it renders alright. |
ianobermiller
added a commit
that referenced
this pull request
Jul 24, 2015
Better support for old and tweener flexbox syntax
|
Woo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 main caveats with supporting the 2009 'old' syntax, first an element with
display: boxis treated as an inline element, andbox-flexaccepts only argument instead of 3 in the latest spec.Fixes #205