This repository was archived by the owner on Aug 19, 2022. It is now read-only.
Consistently require react/addons#312
Merged
ianobermiller merged 2 commits intoFormidableLabs:masterfrom Aug 12, 2015
Merged
Conversation
This could have a speed-up effect, but has not been verified. In any case, it's good to be consistent in how we do things.
modules/__tests__/keyframes-test.js
Outdated
Contributor
There was a problem hiding this comment.
You can keep these as var {Component} = require('react/addons'); any good reason to change it to two lines?
Contributor
Author
There was a problem hiding this comment.
Ha, that's a great point actually... Got carried away from resolve-styles where we actually make use of React! Fix incoming any second now :)
Contributor
|
❤️ |
ianobermiller
added a commit
that referenced
this pull request
Aug 12, 2015
Consistently require react/addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could have a slight speed-up effect, but doing some crude testing hasn't shown this to be of a real significance. In any case, it's good to be consistent in how we do things!