This repository was archived by the owner on Aug 19, 2022. It is now read-only.
[WIP] clear radium state for unmounted components#955
Closed
stefvhuynh wants to merge 3 commits intomasterfrom
Closed
[WIP] clear radium state for unmounted components#955stefvhuynh wants to merge 3 commits intomasterfrom
stefvhuynh wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
@ryan-roemer, @ianobermiller, this is an initial attempt at resolving this issue. Can I get thoughts on the approach? |
1 similar comment
Contributor
|
General approach looks solid. I'm a little nervous about the check in |
Contributor
Author
|
@alexlande, another possible approach would be to expose |
Contributor
|
@stefvhuynh Yeah, it doesn't feel like something that users should have to handle, if we can do it automatically. |
Contributor
Author
|
@alexlande, alright, i'll clean this up then. |
Contributor
Author
|
continued in #956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt to resolve #524.
resolve-styles.jsenhancer.jsenhancer.jsThere is still a lot of cleanup to do, but I'm looking for opinions on the approach.