Skip to content

Chore: updates#121

Merged
ryan-roemer merged 8 commits intomasterfrom
chore/updates-2
Mar 14, 2023
Merged

Chore: updates#121
ryan-roemer merged 8 commits intomasterfrom
chore/updates-2

Conversation

@ryan-roemer
Copy link
Copy Markdown
Member

@ryan-roemer ryan-roemer commented Mar 9, 2023

  • Update devdeps
  • Tighten up lint rules
  • Update CI to modern Node versions

Skipped updates:

$ yarn outdated
                                                                   
@types/react        16.9.35 16.14.35 18.0.28 devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react    
@types/react-dom    16.9.8  16.9.18  18.0.11 devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #121 (e1dc8ba) into master (8004f7f) will not change coverage.
The diff coverage is n/a.

❗ Current head e1dc8ba differs from pull request most recent head c71d72f. Consider uploading reports for the commit c71d72f to get more accurate results

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files           1        1           
  Lines          56       56           
=======================================
  Hits           55       55           
  Misses          1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ryan-roemer ryan-roemer changed the title [WIP] Chore: updates Chore: updates Mar 10, 2023
@BrittanyIRL BrittanyIRL requested a review from exogen March 10, 2023 17:21
Comment thread test/.eslintrc.yml
Element: false
rules:
no-var: 2
prefer-const: 2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plan to migrate the source code off var and onto let/const as well? I noticed there's no build step I imagine it's about browser compatibility?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there's no build step I imagine it's about browser compatibility?

Yep! It's that! So, definitely worth ticketing / reviewing in the future if browser matrix is ready to the point to do that!

@ryan-roemer ryan-roemer marked this pull request as ready for review March 10, 2023 19:40
Copy link
Copy Markdown
Contributor

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much changed besides deps; looks good!

@ryan-roemer ryan-roemer merged commit b34988f into master Mar 14, 2023
@ryan-roemer ryan-roemer deleted the chore/updates-2 branch March 14, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants