Skip to content

Chore: updates #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan-roemer merged 8 commits into from
Mar 14, 2023
Merged

Chore: updates #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
786d266
Start updates
ryan-roemer Mar 9, 2023
b1a21b6
More updates
ryan-roemer Mar 9, 2023
28a3d5a
Next batch
ryan-roemer Mar 9, 2023
c2f1a90
More
ryan-roemer Mar 9, 2023
5b02faa
More
ryan-roemer Mar 9, 2023
106b071
More lint
ryan-roemer Mar 9, 2023
a7937a8
More
ryan-roemer Mar 9, 2023
c71d72f
Last updates
ryan-roemer Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
- ubuntu-latest
- windows-latest
node_version:
- 12
- 14
- 16
- 18
name: Node ${{ matrix.node_version }} on ${{ matrix.os }}
steps:
- name: Use LF EOL
Expand Down
62 changes: 31 additions & 31 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,50 +37,50 @@
},
"homepage": "https://github.com/FormidableLabs/react-fast-compare",
"devDependencies": {
"@babel/core": "^7.7.5",
"@babel/preset-env": "^7.7.6",
"@testing-library/dom": "^7.5.1",
"@testing-library/preact": "^1.0.2",
"@types/node": "^14.0.1",
"@babel/core": "^7.21.0",
"@babel/preset-env": "^7.20.2",
"@testing-library/dom": "^9.0.1",
"@testing-library/preact": "^3.2.3",
"@types/node": "^18.15.0",
"@types/react": "^16.9.35",
"@types/react-dom": "^16.9.8",
"@types/react-redux": "^7.1.9",
"@typescript-eslint/parser": "^2.34.0",
"@types/react-redux": "^7.1.25",
"@typescript-eslint/parser": "^5.54.1",
"assert": "^2.0.0",
"babel-loader": "^8.0.6",
"babel-loader": "^9.1.2",
"benchmark": "^2.1.4",
"builder": "^5.0.0",
"codecov": "^3.8.2",
"core-js": "^3.5.0",
"eslint": "^6.7.2",
"eslint-plugin-react": "^7.20.0",
"fast-deep-equal": "3.1.1",
"fast-deep-equal-git": "epoberezkin/fast-deep-equal#v3.1.1",
"jsdom": "^16.2.2",
"codecov": "^3.8.3",
"core-js": "^3.29.0",
"eslint": "^8.35.0",
"eslint-plugin-react": "^7.32.2",
"fast-deep-equal": "3.1.3",
"fast-deep-equal-git": "epoberezkin/fast-deep-equal#v3.1.3",
"jsdom": "^21.1.0",
"jsdom-global": "^3.0.2",
"karma": "^6.3.14",
"karma-chrome-launcher": "^3.1.0",
"karma-firefox-launcher": "^1.1.0",
"karma-mocha": "^1.3.0",
"karma": "^6.4.1",
"karma-chrome-launcher": "^3.1.1",
"karma-firefox-launcher": "^2.1.2",
"karma-mocha": "^2.0.1",
"karma-mocha-reporter": "^2.2.5",
"karma-safari-launcher": "^1.0.0",
"karma-webpack": "^5.0.0",
"lodash": "^4.17.10",
"mocha": "^6.2.2",
"mocha": "^10.2.0",
"nano-equal": "^2.0.2",
"nyc": "^14.1.1",
"preact": "^10.4.1",
"nyc": "^15.1.0",
"preact": "^10.13.1",
"process": "^0.11.10",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-redux": "^8.0.1",
"react-test-renderer": "^18.0.0",
"redux": "^4.2.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-redux": "^8.0.5",
"react-test-renderer": "^18.2.0",
"redux": "^4.2.1",
"shallow-equal-fuzzy": "0.0.2",
"sinon": "^7.5.0",
"terser": "^4.4.3",
"typescript": "^4.6.3",
"webpack": "^5.72.0"
"sinon": "^15.0.1",
"terser": "^5.16.6",
"typescript": "^4.9.5",
"webpack": "^5.76.0"
},
"nyc": {
"exclude": [
Expand Down
3 changes: 3 additions & 0 deletions test/.eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ settings:
globals:
document: false
Element: false
rules:
no-var: 2
prefer-const: 2
Copy link
Copy Markdown

@exogen exogen Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plan to migrate the source code off var and onto let/const as well? I noticed there's no build step I imagine it's about browser compatibility?

Copy link
Copy Markdown
Member Author

@ryan-roemer ryan-roemer Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there's no build step I imagine it's about browser compatibility?

Yep! It's that! So, definitely worth ticketing / reviewing in the future if browser matrix is ready to the point to do that!

6 changes: 3 additions & 3 deletions test/browser/browser.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

var assert = require('assert');
var sinon = require('sinon');
const assert = require('assert');
const sinon = require('sinon');

var equal = require('../..');
const equal = require('../..');

const element1 = document.createElement('div');
const element2 = document.createElement('div');
Expand Down
4 changes: 1 addition & 3 deletions test/browser/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ module.exports = function(config) {
path.join(
path.dirname(require.resolve('fast-deep-equal-git/package.json')),
'spec'
),
// Transpile all of testing-library's preact stuff.
path.dirname(require.resolve('@testing-library/preact/package.json'))
)
],
loader: 'babel-loader',
options: {
Expand Down
8 changes: 4 additions & 4 deletions test/node/basics.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use strict';

var assert = require('assert');
var sinon = require('sinon');
const assert = require('assert');
const sinon = require('sinon');

var equal = require('../..');
var tests = require('./tests');
const equal = require('../..');
const tests = require('./tests');

describe('basics', function() {
let sandbox;
Expand Down
4 changes: 2 additions & 2 deletions test/node/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
var generic = require('fast-deep-equal-git/spec/tests.js');
var es6 = require('fast-deep-equal-git/spec/es6tests.js');
const generic = require('fast-deep-equal-git/spec/tests.js');
const es6 = require('fast-deep-equal-git/spec/es6tests.js');

const reactElementA = {
'$$typeof': 'react.element',
Expand Down
Loading