Fix markdown.js codepane bug. #302
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes CodePane render bug when using markdown syntax.
Sample presentation code
Note : I attached
Presentationclass without import clause. You can paste and run this code at example/index.js.At current master branch )
After fixes branch )
This happens because CodePane needs source with
props.sourceorchildren, but marked.js (markdown renderer) returnscodeproperty to implement them.I fix additional function by changing property
codetosource, so we don't modifyCodePanenormarked.jssource.