Fix issue #329 #338
Merged
Fix issue #329 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes issue about #329.
In README, Markdown tag has property 'source'. But, It has no usage on codes.
So Markdown class will pass 'null' or 'undefined' value to marked.js,
str.replacemethod makes exception in conclusion.I think this commit makes bugs. (Changes markdown passing logic?)
fe8607d#diff-600386b6077350650f252d685cbe2565
And, I found that
mdastConfigproperty has removed on that commit, So I removed it from README.md together.