Skip to content

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented Jan 13, 2020

Description

Upgrades React Live to v2 and fixes an issue around state updating for the default content in the example. #781

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated tests and verified through example project.

@kale-stew kale-stew merged commit 733617c into master Jan 14, 2020
@kale-stew kale-stew deleted the task/upgrade-react-live branch January 14, 2020 00:34
ryan-roemer added a commit that referenced this pull request Feb 5, 2020
* Upgrade React Live to v2 (#800)

* Upgrade React Live to v2

* Fix Code Pane test

* 5.8.0

* Add correct sub-dir to Readme link paths, fixes #801 (#803)

* Infra: Switch to spectacle-ci AWS user. (#822)

- We are switching to specific AWS users for each lander (with tighter permissions)
- This is against `master` to verify the deploy. Will merge into `task/rewrite` when I'm done.
- Update travis keys. We'll need to merge to verify.
- Minor other fixes.

* Update basename (#829)

We've been firing `/docs/` for things when we should fire `/open-source/spectacle/docs/`

- Add `basename` option for GA wrapper.
- Switch our `prod:build|serve` logic to use simplified symlink like we did in: FormidableLabs/renature#25

Co-authored-by: Carlos Kelly <me@carlos.dev>
Co-authored-by: Kylie Stewart <kylie@kyliestewart.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants