Docs: Update basename for GA for docs #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloskelly13
approved these changes
Feb 4, 2020
This was referenced Feb 4, 2020
ryan-roemer
added a commit
that referenced
this pull request
Feb 5, 2020
* Upgrade React Live to v2 (#800) * Upgrade React Live to v2 * Fix Code Pane test * 5.8.0 * Add correct sub-dir to Readme link paths, fixes #801 (#803) * Infra: Switch to spectacle-ci AWS user. (#822) - We are switching to specific AWS users for each lander (with tighter permissions) - This is against `master` to verify the deploy. Will merge into `task/rewrite` when I'm done. - Update travis keys. We'll need to merge to verify. - Minor other fixes. * Update basename (#829) We've been firing `/docs/` for things when we should fire `/open-source/spectacle/docs/` - Add `basename` option for GA wrapper. - Switch our `prod:build|serve` logic to use simplified symlink like we did in: FormidableLabs/renature#25 Co-authored-by: Carlos Kelly <me@carlos.dev> Co-authored-by: Kylie Stewart <kylie@kyliestewart.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been firing
/docs/for things when we should fire/open-source/spectacle/docs/basenameoption for GA wrapper.prod:build|servelogic to use simplified symlink like we did in: Docs: Simplifyprod:serverenature#25Note that we're probably going to have to merge to see if it fires completely correctly, but I'll see if staging can detect it...
/cc @carlos-kelly @kale-stew @boygirl @formidableamy