fix: handle device rotations from before app start#309
Open
PhilLab wants to merge 1 commit into
Open
Conversation
Previously, both images and videos where stored with the wrong orientation if you had rotated the phone to landscape before opening the app. Only rotations while the camera app is open were handled by the listener. The target rotation also needs to be applied immediately at bind time, to correctly react to rotations that happened before the app lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Previously, both images and videos where stored with the wrong orientation if you had rotated the phone to landscape before opening the app. Only rotations while the camera app is open were handled by the listener.
The target rotation also needs to be applied immediately at bind time, to correctly react to rotations that happened before the app lifecycle.
The commit also addresses linter warnings in the same file. I figured they are too small to justify a separate PR, but let me know if they shall be removed again.
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).