DRAFT: Yubikey Enhancements - #509
Draft
Fahrj wants to merge 16 commits into
Draft
Conversation
This might change behavior of `RotateKeyWithBackend` since `backend` is no longer used!
This commit serves as preparation for the handling of custom algorithms and slot numbers.
When creating new key, the options such as PIN policy only have to be provided, but not to be applied.
If the certificate only exists on disk, it is essentially bound to that machine. By storing in on the YubiKey directly, it can easily be reused.
Depending on the YubiKey Version, either `KeyInfo` or the attestation certificate are used to get the key's public bytes, if existing.
If key or cert are already present in the given YubiKey PIV slot, they are re-used unless `yk-overwrite` is given on the CLI.
When loading key data from disk, immediately verify whether the certificate is signed by the specified private key. This e.g. catches if the wrong YubiKey is inserted.
Fahrj
force-pushed
the
yubikey_enhancements-split-additions
branch
from
August 20, 2026 12:12
4ea7414 to
1c0fd82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of @bsingh-kpt in #474, but additionally fixes some bugs and adds more features.
The commits are separated in a best effort attempt to distinguish different features and fixes.
Most significant features:
Closes #471