Help understanding MusicBrainz results #627
-
|
I am trying to make the MusicBrainz stage work with weights, but I can't make sense of the results I'm getting. Situation:
Spotify track: https://open.spotify.com/track/1FvDJ9KGxcqwv1utyPL3JZ Given that Could you help me understand, please? Am I missing something? Config "sources": [
{
"data": {
"clientId": "REDACTED",
"clientSecret": "REDACTED"
},
"enable": true,
"id": "spotify",
"name": "spotify",
"options": {
"playTransform": {
"preCompare": [
{
"artists": [
{
"replace": "Аквариум",
"search": "Aquarium"
},
{
"replace": "ДахаБраха",
"search": "DakhaBrakha"
},
... Other renames
],
"name": "ArtistRenames",
"type": "user"
},
{
"name": "CustomCleanup",
"title": [
"/\\s[–—−‐-]\\s(?:[0-9]+\\s)?Remaster(ed)?/i",
"/\\((?:[0-9]+\\s)?Remaster(ed)?\\)/i",
"/\\s?(?:\\([0-9]+['\"\"`'′″]+\\s+Version\\))/i",
"/\\s?[–—−‐-]\\s[0-9]+['\"\"`'′″]+\\s+Version/i"
],
"type": "user"
},
{
"name": "MusicBrainz",
"onFailure": "continue",
"onSuccess": "stop",
"type": "musicbrainz"
},
{
"type": "native"
}
]
},
"scrobbleBacklog": true
},
"type": "spotify"
}
],
"transformers": [
{
"data": {
"apis": [
{
"contact": "<REDACTED>",
}
]
},
"defaults": {
"albumWeight": 0.5,
"artistWeight": 0.3,
"titleWeight": 0.2
"releaseStatusPriority": [
"pseudo-release",
"official"
],
"searchArtistMethod": "native",
"searchOrder": [
"isrc",
"basic",
"artist"
],
},
"name": "MusicBrainz",
"type": "musicbrainz"
}
]
LogsScrobble logs Debug info |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Hey, thanks again for the detailed logs and debug information! Sorry you are having to find all these bugs yourself 😅 The musicbrainz transform is pretty complicated, especially with all the config I implemented, so there have been more overlooked bugs not covered by the existing tests. In this case, your transformer defaults configuration is correct but it is being merged with the specific MB transform config (in spotify source) that was erroneously assigned a default value for the weights, causing them to be I've fixed this bug in this commit and its now available, along with the priority fix, in the I'll devote some time soon to adding more coverage in the musicbrainz test suite 😅 or, if you'd like to submit a PR with more tests I'm happy to accept it and fix any failing tests! |
Beta Was this translation helpful? Give feedback.
-
|
Everything works now. Thanks! Config "transformers": [
{
"data": {
"apis": [
{
"contact": "REDACTED",
}
]
},
"defaults": {
"albumWeight": 0.4,
"artistWeight": 0.3,
"titleWeight": 0.3,
"releaseStatusPriority": [
"official",
"pseudo-release"
],
"searchArtistMethod": "native",
"searchOrder": [
"isrc",
"basic",
"artist"
],
},
"name": "MusicBrainz",
"type": "musicbrainz"
}
]
Now for the album "The Smiths" I'm getting other scores also became non-zero: I don't have any experience with TypeScript, but I'll have a look at test cases 🙇 |
Beta Was this translation helpful? Give feedback.
Hey, thanks again for the detailed logs and debug information! Sorry you are having to find all these bugs yourself 😅 The musicbrainz transform is pretty complicated, especially with all the config I implemented, so there have been more overlooked bugs not covered by the existing tests.
In this case, your transformer defaults configuration is correct but it is being merged with the specific MB transform config (in spotify source) that was erroneously assigned a default value for the weights, causing them to be
0.I've fixed this bug in this commit and its now available, along with the priority fix, in the
edgedocker image or this specific digest: