chore(release): 1.4.1 — the gate that wasn't there - #55
Merged
Conversation
1.4.0 was named for silent failures and shipped with one of its own. It fixed the token budget behind the empty and truncated definitions, and that fix holds. It did not fix the failure underneath, which was never the budget: nothing checked whether what consolidation wrote was about anything. Ships #52. Verified end-to-end on a real store: same dream, same model, only the gate changed, regressions 2 -> 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGqQGN6tcEQcE9bX1VAboL
There was a problem hiding this comment.
🟡 Not ready to approve
The repo’s committed package-lock.json still declares version 1.4.0, leaving the lockfile inconsistent with the 1.4.1 bump.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Release chore for cortex-engine v1.4.1, updating the published package version and documenting the release rationale/fix in the changelog.
Changes:
- Bump npm package version to
1.4.1. - Add a
1.4.1changelog entry describing the new thought-quality “gate”.
File summaries
| File | Description |
|---|---|
| package.json | Bumps package version to 1.4.1 for release. |
| CHANGELOG.md | Adds the 1.4.1 release notes and the fixed-item summary. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| { | ||
| "name": "@fozikio/cortex-engine", | ||
| "version": "1.4.0", | ||
| "version": "1.4.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases #52.
1.4.0 was named for silent failures and shipped with one of its own. It fixed the token budget behind the empty and truncated definitions — that fix holds, and no truncation has appeared in any verification run since. It did not fix the failure underneath, which was never the budget: nothing checked whether what consolidation wrote was about anything.
Verified end-to-end on a real store — same dream, same corpus, same model, only the gate changed:
Local: 312 tests pass, build clean, version bumped, CHANGELOG entry added.
Merging this then tagging \�1.4.1\ triggers the OIDC publish.
Known and filed, not in this release: #53 (connect writes \Concept A/B\ into 82% of edge evidence, which refine then echoes) and #54 (markdown leak check is anchored to start, so abstract leaks bold mid-text into names).