Skip to content

Fix clang-tidy-check: distinguish tooling failures from issue detection #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenc-FNAL merged 5 commits into from
Feb 24, 2026
Merged

Fix clang-tidy-check: distinguish tooling failures from issue detection #357

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec190e9
Initial plan
Copilot Feb 24, 2026
4e5501f
Distinguish clang-tidy tooling failures from issue detection
Copilot Feb 24, 2026
014623b
Fix clang-tidy failure detection: check log content not fixes file
greenc-FNAL Feb 24, 2026
7dbc65f
Bypass early exit due to `exit_on_error`
greenc-FNAL Feb 24, 2026
a579665
Remove unwanted whitespace
greenc-FNAL Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/clang-tidy-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,18 @@ jobs:
cd "$GITHUB_WORKSPACE/phlex-build"

echo "➡️ Running clang-tidy checks..."
cmake --build . --target clang-tidy-check -- --export-fixes clang-tidy-fixes.yaml > clang-tidy.log 2>&1 || true
if [ -s clang-tidy-fixes.yaml ]; then
cmake_status=0
cmake --build . --target clang-tidy-check -- --export-fixes clang-tidy-fixes.yaml > clang-tidy.log 2>&1 || cmake_status=$?

# Distinguish tooling failures from issue detection by checking log content
if [ "$cmake_status" -ne 0 ]; then
if ! grep -qE '^/.+\.(cpp|hpp|c|h):[0-9]+:[0-9]+: (warning|error):' clang-tidy.log; then
echo "::error::clang-tidy failed without producing diagnostic output (exit code $cmake_status)"
exit "$cmake_status"
fi
fi

if grep -qE '^/.+\.(cpp|hpp|c|h):[0-9]+:[0-9]+: (warning|error):' clang-tidy.log; then
echo "has_issues=true" >> "$GITHUB_OUTPUT"
echo "::warning::Clang-tidy found issues in the code"
echo "Error count by check (full details in clang-tidy-log artifact):"
Expand Down
Loading