clang-tidy: resolve readability-qualified-auto - #759
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe change applies explicit pointer and const-qualified local declarations across ROOT storage and phlex graph code, updates three configuration-test expectations, and marks the corresponding clang-tidy check as fixed. ChangesClang-tidy pointer and constness cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@form/root_storage/root_tbranch_read_container.cpp`:
- Around line 63-70: Rename the touched local variables to lower_case names: use
dict_info at both sites in form/root_storage/root_tbranch_read_container.cpp
(lines 63-70 and 104), fund_info at line 114 in that file, and dict_info at line
76 in form/root_storage/root_tbranch_write_container.cpp. Update all references
within their respective scopes consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6a257ace-7606-4ef5-b037-88ff36cdc641
📒 Files selected for processing (8)
docs/dev/clang-tidy-fixes-2026-04.mdform/root_storage/root_tbranch_read_container.cppform/root_storage/root_tbranch_write_container.cppphlex/core/framework_graph.cppphlex/core/make_computational_edges.cppphlex/core/node_catalog.cppphlex/model/data_layer_hierarchy.cpptest/adjust_config.cpp
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: build (gcc, none)
- GitHub Check: Analyze cpp with CodeQL
- GitHub Check: coverage
- GitHub Check: clang-tidy-check
🧰 Additional context used
📓 Path-based instructions (3)
**/*.md
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.md: All Markdown files must follow markdownlint rule MD012: no multiple consecutive blank lines (never more than one blank line in a row)
All Markdown files must follow markdownlint rule MD022: headings must be surrounded by exactly one blank line before and after
All Markdown files must follow markdownlint rule MD031: fenced code blocks must be surrounded by exactly one blank line before and after
All Markdown files must follow markdownlint rule MD032: lists must be surrounded by exactly one blank line before and after (including after headings and code blocks)
All Markdown files must follow markdownlint rule MD034: no bare URLs (use markdown link syntax like[text](destination)instead of plain URLs)
All Markdown files must follow markdownlint rule MD036: use # headings for titles, not Bold:
All Markdown files must follow markdownlint rule MD040: always specify code block language (for example, use 'bash', 'python', '```text', etc.)
**/*.md: Do not use multiple consecutive blank lines in Markdown (MD012)
Surround Markdown headings with exactly one blank line (MD022)
Surround Markdown fenced code blocks with exactly one blank line (MD031)
Surround Markdown lists with exactly one blank line (MD032)
Do not use bare URLs in Markdown; use[text](url)syntax instead (MD034)
Use#headings in Markdown, not**Bold**for section titles (MD036)
Always specify language on fenced code blocks in Markdown (MD040)
Files:
docs/dev/clang-tidy-fixes-2026-04.md
**/*.{cpp,cc,cxx,h,hpp}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{cpp,cc,cxx,h,hpp}: Use clang-format tool for all C++ code formatting (VS Code auto-formats on save); configuration defined in.clang-formatwith 100-character line limit and 2-space indentation
Follow clang-tidy recommendations defined in.clang-tidy
Files:
phlex/core/framework_graph.cppphlex/model/data_layer_hierarchy.cppphlex/core/node_catalog.cppform/root_storage/root_tbranch_write_container.cppphlex/core/make_computational_edges.cppform/root_storage/root_tbranch_read_container.cpptest/adjust_config.cpp
**/*.{hpp,cpp}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{hpp,cpp}: Use.hppfor header files,.cppfor implementation, and*_test.cppfor test files in C++
Enforce 100-character line limit and 2-space indentation in C++ code via.clang-format
UseQualifierAlignment: Right(east-const) style:int const xnotconst int xin C++
UsePointerAlignment: Leftin C++ (pointer*attached to type, not variable name)
All C++ identifiers must uselower_casenaming: namespaces, classes, structs, enums, functions, variables, parameters, members, and constants
Exception to C++ naming: template parameters useCamelCase
Exception to C++ naming: macros useUPPER_CASE
Private, protected, and constant members in C++ must have a trailing underscore (_), no trailing underscore on anything else
Useenum classpreferred over plainenumin C++
Usestd::shared_ptrfor shared ownership,std::unique_ptrfor exclusive ownership, raw pointers for non-owning references only in C++
Use functors with agent-noun pattern:ModelEvaluator evaluate_model(...)in C++
Apply.clang-tidychecks for bugprone, cert, clang-analyzer, concurrency, cppcoreguidelines, misc, modernize, performance, portability, and readability as defined in the.clang-tidyconfiguration file
Usephlex::namespace for core code,phlex::experimental::for experimental features in C++
Files:
phlex/core/framework_graph.cppphlex/model/data_layer_hierarchy.cppphlex/core/node_catalog.cppform/root_storage/root_tbranch_write_container.cppphlex/core/make_computational_edges.cppform/root_storage/root_tbranch_read_container.cpptest/adjust_config.cpp
🔇 Additional comments (7)
form/root_storage/root_tbranch_read_container.cpp (1)
163-163: LGTM!phlex/core/framework_graph.cpp (1)
190-192: LGTM!Also applies to: 194-194
phlex/core/make_computational_edges.cpp (1)
86-86: LGTM!Also applies to: 150-150
phlex/core/node_catalog.cpp (1)
31-31: LGTM!Also applies to: 34-34, 37-37, 40-40, 43-43, 46-46, 65-65
phlex/model/data_layer_hierarchy.cpp (1)
117-117: LGTM!test/adjust_config.cpp (1)
32-32: LGTM!Also applies to: 45-45, 57-57
docs/dev/clang-tidy-fixes-2026-04.md (1)
160-161: LGTM!
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
- Coverage 83.86% 83.81% -0.06%
==========================================
Files 172 172
Lines 7203 7203
Branches 845 845
==========================================
- Hits 6041 6037 -4
- Misses 883 884 +1
- Partials 279 282 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
535379d to
52eda47
Compare
2 participants
Resolve
readability-qualified-autoclang-tidy warnings.readability-qualified-autoclang-tidy warnings by making pointer and const-pointer type deductions explicit across ROOT storage, framework graph, computational edges, node catalog, and data-layer hierarchy code.test/adjust_config.cppfor malformed configurations specifying bothcppandpy.#759indocs/dev/clang-tidy-fixes-2026-04.md.