clang-tidy: resolve readability-redundant-casting

[knoepfel]

Resolve readability-redundant-casting clang-tidy warnings.

• Code quality: Resolved readability-redundant-casting clang-tidy warnings by removing redundant ownership casts in branch-buffer allocation and TTree initialization.
• Tests: Removed an unnecessary static_cast from the fundamental scalar round-trip test.
• Documentation: Marked the clang-tidy fix as complete and recorded PR #783.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8ee93540-8b9f-4243-b956-5fe8c2835344

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR removes redundant ownership and character casts from ROOT storage code and a related test, then marks the corresponding clang-tidy finding as resolved.

Changes

Redundant cast cleanup

Layer / File(s)	Summary
ROOT storage allocation cleanup form/root_storage/root_tbranch_read_container.cpp, form/root_storage/root_ttree_write_container.cpp	ROOT object allocations are passed directly to branchBuffer and m_tree.reset.
Test and checklist alignment test/form/form_storage_test.cpp, docs/dev/clang-tidy-fixes-2026-04.md	The scalar test passes the character literal directly, and the redundant-casting clang-tidy item is marked complete.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• Framework-R-D/phlex#743: Touches the same setupWrite implementation in root_ttree_write_container.cpp.

Suggested reviewers: greenc-fnal

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: resolving the clang-tidy readability-redundant-casting warning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   83.90%   83.83%   -0.07%     
==========================================
  Files         172      172              
  Lines        7231     7231              
  Branches      850      850              
==========================================
- Hits         6067     6062       -5     
- Misses        883      888       +5     
  Partials      281      281              

Flag	Coverage Δ
scripts	80.09% <ø> (ø)
unittests	85.70% <100.00%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/root_storage/root_tbranch_read_container.cpp	87.02% <100.00%> (ø)
form/root_storage/root_ttree_write_container.cpp	54.54% <100.00%> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d352f0f...0ae04dc. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.