Python GUI Fixes - #43
Merged
Merged
Conversation
All buttons would open the same URL because we capture the variable and not the value. So the variable would get updated to the last loop value in every lambda. With default parameter, we don't capture the value. See: https://gist.github.com/gisbi-kim/2e5648225cc118fc72ac933ef63c2d64 Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Make firmware_update.py same as in FrameworkComputer/ledmatrix-rs Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
fix-loop
branch
from
November 26, 2024 06:24
0bfdce2 to
db5ea4b
Compare
More friendly Signed-off-by: Daniel Schaefer <dhs@frame.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.