[pull] master from facebook:master#809
Merged
pull[bot] merged 3 commits intoFreddyZeng:masterfrom Sep 3, 2020
Merged
Conversation
Summary: This type makes more sense as an interface, given a class would be a common implementation (and object types aren't supported in that case). It also adds the names of the parameters so it's easier to understand for implementers. Changelog: [General][Changed] - Changed type definition of IPerformanceLogger from object to interface Reviewed By: lunaleaps Differential Revision: D23449816 fbshipit-source-id: be872748827b123587f3f397da20f5545b0aae07
Summary: Changelog: [Added] Added custom method `setPerformanceLogger` to `XMLHttpRequest` Reviewed By: lunaleaps Differential Revision: D23129945 fbshipit-source-id: 7a295945eee2b2f81dc0a46f764ffb1d9b14af15
…ger if available Summary: Changelog: [Changed] Used scoped performance logger to mark the beginning and end of the call to the renderer, instead of using `GlobalPerformanceLogger`. Reviewed By: lunaleaps Differential Revision: D23240784 fbshipit-source-id: 7099f1a4b5da3f29596fcee289a715d295ae0a65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )