Skip to content

[TD]fix Balloon positioning#30895

Merged
Lgt2x merged 1 commit into
FreeCAD:mainfrom
WandererFan:BalloonShifts
Jul 19, 2026
Merged

[TD]fix Balloon positioning#30895
Lgt2x merged 1 commit into
FreeCAD:mainfrom
WandererFan:BalloonShifts

Conversation

@WandererFan

Copy link
Copy Markdown
Contributor

This PR implements a fix for issue #30734. The issue was introduced by PR #30154 which neglected to special case the handling of Balloons.

Balloons are positioned within a parent view, while other views are positioned on the page. The fix overrides the default view position setting logic in QGIView which does not apply to balloons.

Note that Leader Lines also require special positioning and may require a similar change in a separate PR.

before change:
BalloonShifts_before

after change:
BalloonShifts_after

@github-actions github-actions Bot added Status: Needs triage Missing triage Mod: TechDraw Related to the TechDraw Workbench Language: C++ labels Jun 21, 2026
@WandererFan WandererFan linked an issue Jun 21, 2026 that may be closed by this pull request
@maxwxyz maxwxyz added Type: Bug This issue or PR is related to a bug Requires: Testing The PR needs testing by users and developers Requires: Code Review The PR requires code to be reviewed and removed Status: Needs triage Missing triage labels Jun 21, 2026
@maxwxyz maxwxyz moved this from Queue to Approved in Merge Queue Jun 21, 2026
@maxwxyz maxwxyz moved this from Approved to Merge Meeting in Merge Queue Jun 21, 2026
@maxwxyz maxwxyz added this to the 26.3 milestone Jun 21, 2026

@ryankembrey ryankembrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwxyz Tested, fixes the issue.

Image

@maxwxyz maxwxyz added Approved: Tested The PR was manually tested and approved and removed Requires: Testing The PR needs testing by users and developers labels Jun 21, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jun 21, 2026

@FEA-eng FEA-eng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issue also for me (I've noticed it here)

Comment thread src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
@Lgt2x Lgt2x added Approved: Code Quality The PR was checked for code quality and approved and removed Requires: Code Review The PR requires code to be reviewed labels Jul 19, 2026
@Lgt2x
Lgt2x enabled auto-merge (rebase) July 19, 2026 13:34
@Lgt2x
Lgt2x merged commit d10ffb5 into FreeCAD:main Jul 19, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Merge Queue Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved Approved: Tested The PR was manually tested and approved Language: C++ Mod: TechDraw Related to the TechDraw Workbench Type: Bug This issue or PR is related to a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechDraw: Balloon shifts when it is created

5 participants