Gui: prepare 3D rendering and visual test infrastructure for new renderer#31187
Merged
Conversation
tritao
force-pushed
the
prep-render-backend-groundwork
branch
10 times, most recently
from
July 11, 2026 09:32
6c44bbd to
4ae07ce
Compare
tritao
marked this pull request as ready for review
July 11, 2026 09:33
tritao
force-pushed
the
prep-render-backend-groundwork
branch
4 times, most recently
from
July 11, 2026 12:14
4289cd3 to
beb482c
Compare
Separate datum-label scene synchronization from GL traversal so legacy and alternate render actions can consume the same retained geometry and text representation.
Fold the standalone SoFCColorBar snapshot coverage into the consolidated presentation change.
tritao
force-pushed
the
prep-render-backend-groundwork
branch
from
July 18, 2026 19:16
90d3f62 to
66907e0
Compare
Contributor
Author
|
Did one more audit on this and found some minor issues worth fixing, sent another push with these:
|
|
What should I test? |
Member
|
@pierreporte see above #31187 (review) :) |
|
I haven’t seen any visual problem with things listed in #31187 (review). Quite a lot of coin messages in the terminale that do not appear in the weekly:
|
Contributor
Author
|
Thanks for testing. Those are fixed by #31112 |
pierreporte
approved these changes
Jul 18, 2026
Member
|
Good to go then! Individual commits make sense, will not squash on merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks FreeCAD’s current Coin-based renderer and visual test suite around a cleaner retained-mode foundation. Scene construction, screen-space geometry, mesh render data, framebuffer capture, and teardown are made more explicit, deterministic, and reusable while preserving the existing rendering path.
The result gives the follow-up PR a smaller and clearer integration surface for adding the new renderer, with less duplicated scene preparation and stronger visual-test contracts.
Viewer and framebuffer capture
renderToImage()for controlled raster capture.grabFramebuffer()for live viewport capture.Retained scene-graph infrastructure
Introduces
SoFCScreenSpaceGroupfor shared screen-space scene preparation.Modernizes retained geometry for:
Extracts
TranslateManip.Removes the unused
SoTextLabelnode.Makes background, label, annotation, placement-indicator, and NaviCube rendering more deterministic.
Separates bounding-box preparation and screen-space geometry state from rendering state.
Visual test infrastructure
Teardown and lifecycle handling
Scope
This PR establishes the retained scene and visual-testing infrastructure needed by the next renderer integration. It does not add the new renderer or bump Coin.
This work is part of the broader rendering and selection modernization effort tracked in FreeCAD/FPA-grant-proposals#35.