Skip to content

Conversation

@mysterywolf
Copy link
Contributor

@mysterywolf mysterywolf commented Apr 14, 2021

use space to replace tab and remove meaningless space in the end of each line

Description

  1. use Space(4 spaces) to replace Tab to prevent that there are Spaces and Tab mixed in files.
  2. remove meaningless space in the end of each line

Test Steps

Related Issue

negative

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mysterywolf mysterywolf requested a review from a team as a code owner April 14, 2021 17:27
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #310 (17a678c) into main (99295c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files           3        3           
  Lines         532      532           
  Branches      142      142           
=======================================
  Hits          482      482           
  Misses         14       14           
  Partials       36       36           
Flag Coverage Δ
unittests 90.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99295c9...17a678c. Read the comment docs.

@AniruddhaKanhere
Copy link
Member

Hello @mysterywolf,

First of all, thank you for this PR!

All these changes seem to be very harmless. But, there is a catch: in the past, we have tried doing this but it broke some of the toolchains. Some of the toolchains don't handle the changing of tabs to spaces very well.

So, here is what I would recommend as a path forward:

  • We can easily accept changes that are not in the portable directory like the ones in include/croutine.h.
  • But for the changes in the portable directory, we would require that it should be done one port at a time. The rationale being that if something breaks, we can roll back the change easily without affecting other changes. And it'll be easier to test and review.
  • In essence, there should be multiple PRs touching one port at a time.

Thanks again! Do ask if you have any questions or concerns.

@mysterywolf
Copy link
Contributor Author

OK thanks for you recommend, I will ignore portable directory (except portable/MemMang), and deal with other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants