Skip to content

add i18n-eslint-plugin#4242

Closed
ChunkyProgrammer wants to merge 16 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:use-i18n-eslint-plugin
Closed

add i18n-eslint-plugin#4242
ChunkyProgrammer wants to merge 16 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:use-i18n-eslint-plugin

Conversation

@ChunkyProgrammer
Copy link
Copy Markdown
Member

@ChunkyProgrammer ChunkyProgrammer commented Oct 27, 2023

Add i18n-eslint-plugin

Pull Request Type

  • Dev enhancement

Description

It is configured to find keys that don't exist and raw text instead of translated text in vue files

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@github-actions github-actions Bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 27, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 27, 2023 23:13
ChunkyProgrammer
ChunkyProgrammer commented Oct 27, 2023
View reviewed changes
Comment thread .eslintrc.js
@kommunarr
Copy link
Copy Markdown
Collaborator

kommunarr commented Oct 28, 2023

It still misses things like the More Options in ft-list-video. Is this a shortcoming of the plugin?

@ChunkyProgrammer
Copy link
Copy Markdown
Member Author

ChunkyProgrammer commented Oct 28, 2023

It still misses things like the More Options in ft-list-video. Is this a shortcoming of the plugin?

I'll see if i can configure it (it's not the html property title, it's a vue property which is why I think it's not being checked by default)

FreeTube/src/renderer/components/ft-icon-button/ft-icon-button.js

Line 11 in 6d6fc73

title: {

@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft October 28, 2023 01:46
auto-merge was automatically disabled October 28, 2023 01:46

Pull request was converted to draft

@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 28, 2023
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review October 28, 2023 15:16
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 28, 2023 15:17
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 28, 2023
absidue
absidue reviewed Oct 28, 2023
View reviewed changes
Comment thread src/renderer/components/proxy-settings/proxy-settings.vue Outdated
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 31, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 31, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Oct 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE
PikachuEXE reviewed Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid more conflict to #4234 I am gonna approve this thing later

Also if you want checkmark translated you might want to name it something else (instead of "checkmark", I imagine a translator watching that key and got no idea how to "translate" it)

PikachuEXE
PikachuEXE reviewed Dec 11, 2023
View reviewed changes
Comment thread .eslintrc.js Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 31, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Jan 3, 2024
@github-actions github-actions Bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer
Copy link
Copy Markdown
Member Author

ChunkyProgrammer commented Jan 5, 2024

Seems to be some weird issues with this PR, I'll look into it more and maybe reopen

auto-merge was automatically disabled January 5, 2024 06:15

Pull request was closed

@ChunkyProgrammer ChunkyProgrammer mentioned this pull request Mar 13, 2024
Merged
1 task
@ChunkyProgrammer ChunkyProgrammer deleted the use-i18n-eslint-plugin branch January 20, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE left review comments

@absidue absidue Awaiting requested review from absidue

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees

No one assigned

Labels

PR: dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChunkyProgrammer @kommunarr @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc