Skip to content

Fix: Opening a playlist from a user playlist reloads the view twice - #9525

Open
Shadorc wants to merge 4 commits into
FreeTubeApp:developmentfrom
Shadorc:fix/playlist-flicker
Open

Fix: Opening a playlist from a user playlist reloads the view twice#9525
Shadorc wants to merge 4 commits into
FreeTubeApp:developmentfrom
Shadorc:fix/playlist-flicker

Conversation

@Shadorc

@Shadorc Shadorc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #9517
closes #9513 (side effect)

Description

Early exit from watchers that are triggering redundant calls to getPlaylistInfo (debounced or not).
For the fix to work, the state of the playlist needs to be reset, otherwise everyting break on route change. This has the added benefit of fixing issue #9513 too.

Testing

Valid playlist

  1. Open a user playlist
  2. Enter a valid playlist URL in the search bar
  3. Check that the UI does not reload after the first load and does not cause a flicker

Invalid playlist

  1. Open a user playlist
  2. Enter an invalid playlist URL in the search bar (e.g. https://www.youtube.com/playlist?list=foobar)
  3. Check that the UI does not break and display The playlist currently has no videos.

Desktop

  • OS: Bazzite
  • OS Version:
  • FreeTube version: v0.25.1-beta

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 29, 2026 10:24
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 29, 2026
Comment thread src/renderer/helpers/utils.js
auto-merge was automatically disabled July 29, 2026 12:28

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 29, 2026 12:29
@PikachuEXE

Copy link
Copy Markdown
Member

Saw from #9517

Open a playlist
Enter another playlist URL in the search bar (e.g. https://www.youtube.com/playlist?list=foobar), can be valid or invalid
Observe that the UI reloads after the first load and causes a flicker

But is it online playlist or user playlist for 1 & 2? I want to reproduce it first

@Shadorc Shadorc changed the title Fix: Opening a playlist from another playlist reloads the view twice Fix: Opening a playlist from a user playlist reloads the view twice Jul 30, 2026
@Shadorc

Shadorc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

But is it online playlist or user playlist for 1 & 2? I want to reproduce it first

User playlists are playlists specific to FreeTube, available in the Playlists tab, right?
If so, is it possible to open a user playlist from a URL?

I have updated this MR title and the issue title + repro steps to be clearer

It does not happen with two YouTube playlists because the issue comes from a change in the selectedUserPlaylistVideos array (it becomes empty when switching to a YouTube playlist).
If it's possible to switch to a user playlist from another user playlists, then the issue would also happen if the two playlists have a different number of videos.

Comment thread src/renderer/views/Playlist/Playlist.vue Outdated
auto-merge was automatically disabled July 31, 2026 13:59

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 31, 2026 14:00
auto-merge was automatically disabled July 31, 2026 14:19

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 31, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Opening a playlist from a user playlist reloads the view twice [Bug]: Opening an invalid playlist from a user playlist breaks UI

3 participants