Skip to content

probe: profile T5 default path on CI (temporary, never merged)#152

Merged
JohnnyWilson16 merged 1 commit into
mainfrom
probe/ci-profile-t5
Jul 18, 2026
Merged

probe: profile T5 default path on CI (temporary, never merged)#152
JohnnyWilson16 merged 1 commit into
mainfrom
probe/ci-profile-t5

Conversation

@JohnnyWilson16

@JohnnyWilson16 JohnnyWilson16 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue/feature description.

Fixes # (issue number if applicable)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor / Style / Performance improvement

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Type checks (mypy) and linter checks (ruff) pass locally

Summary by CodeRabbit

  • Chores
    • Updated performance validation to continue reporting results without blocking the workflow when a benchmark gate fails.
    • Added profiling diagnostics for the default T5 cleaning process to help identify performance bottlenecks.
    • Improved visibility into cumulative processing time during performance checks.

@strix-security

Copy link
Copy Markdown
Contributor

Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here.

@JohnnyWilson16
JohnnyWilson16 merged commit ac4040f into main Jul 18, 2026
14 checks passed
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a448299d-cd75-4969-8404-c84255a82bdb

📥 Commits

Reviewing files that changed from the base of the PR and between 9368ea4 and eb859e4.

📒 Files selected for processing (1)
  • .github/workflows/perf-regression.yml

📝 Walkthrough

Walkthrough

Changes

Performance workflow

Layer / File(s) Summary
T5 gate handling
.github/workflows/perf-regression.yml
The T5 gate command tolerates non-zero exit status so detected regressions do not fail the workflow.
T5 profiling probe
.github/workflows/perf-regression.yml
A probe warms up and profiles the default T5 cleaning flow, printing the top freshdata functions by cumulative time.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: johnnywilson-portfolio

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch probe/ci-profile-t5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant