docs: link subpackages to architecture map - #174
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
🚧 Files skipped from review as they are similar to previous changes (17)
📝 WalkthroughWalkthroughSeventeen subpackage docstrings now link to ChangesArchitecture documentation links
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. So far, Strix has reviewed 36 pull requests, surfaced 3 security issues (1 critical/high) and blocked 1 risky merge across this workspace. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33f50fa05b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """Optional framework adapters (Polars, etc.).""" | ||
| """Optional framework adapters (Polars, etc.). | ||
|
|
||
| See ``ARCHITECTURE.md`` for how this package fits into the overall cleaning flow. |
There was a problem hiding this comment.
Make the architecture breadcrumb an actual link
The double-backtick syntax renders ARCHITECTURE.md only as inline code and provides no hyperlink target. This same addition appears in every changed package, so readers viewing the generated docstring or browsing an src/freshdata/<package>/__init__.py cannot follow the promised breadcrumb to the repository-root file. Use an explicit repository URL or another valid link target so the source-first navigation described by this change actually works.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 3deb9b3: all 17 added breadcrumbs now use an explicit reStructuredText link to the repository-root ARCHITECTURE.md, so they are clickable both in rendered docstrings and from source-oriented documentation. Revalidation passed Ruff, mypy across 201 source files, the 17/17 docstring-link check, git diff --check, and the full fast lane (4,051 passed, 6 skipped; 93.16% coverage).
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
kevincostner17
left a comment
There was a problem hiding this comment.
Verdict: Valid — approve
Checked against #161 acceptance criteria.
Acceptance criteria (#161)
| Criterion | Status |
|---|---|
| Docstrings only — no behavior change | Pass — only __init__.py docstrings touched, +55/−2 |
ruff check . and mypy src/freshdata pass |
Pass (CI green) |
| Fast test lane stays green | Pass — 4,051 passed, 93.16% coverage |
Verification
- All 17 subpackages listed in issue #161 have the breadcrumb: engine, steps, imputation, domains, semantic, context, enterprise, compliance, execution, streaming, parsers, render, models, learning, integrations, adapters, experimental. ✓
ARCHITECTURE.mdexists on main (added in #158). Link URL is correct. ✓import freshdataworks fine after the change. ✓- The breadcrumb text is consistent across all 17 files — same RST link format, same wording. ✓
- Adapters and imputation docstrings got slightly expanded descriptions alongside the breadcrumb, which is a nice touch. ✓
CI
All checks green: quality-fast, truthbench, test-matrix (3.9–3.13), build, benchmark, plugin-contract, reproducibility, gauntlet, wheel-guard.
Clean, mechanical docs PR — exactly what #161 asked for. Good to merge.
Summary
ARCHITECTURE.mdbreadcrumb to every top-level subpackage listed in the architecture mapCloses #161.
Validation
ruff check .mypy --python-version 3.12 src/freshdata— 201 source filespytest -m "not online and not large"— 4,051 passed, 6 skipped, 12 deselected; 93.16% coveragegit diff --checkSummary by CodeRabbit