Skip to content

Conversation

@thirsch
Copy link

@thirsch thirsch commented Feb 11, 2024

This pr fixes the test deprecations for using mockery 1.6.7 and php 8.2 and re-enables the deprecation helper. Closes #8

@thirsch thirsch requested review from connorhu and thePanz February 11, 2024 19:25
Copy link
Member

@thePanz thePanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved

Not sure why the "rebase branch" button is not showing up anymore, as it does for the SF1 repo

@thePanz thePanz merged commit 7be2ad5 into FriendsOfSymfony1:6.x Feb 11, 2024
@thirsch thirsch deleted the feature/fix-test-deprecations branch February 11, 2024 19:53
@thirsch
Copy link
Author

thirsch commented Feb 11, 2024

Not sure why the "rebase branch" button is not showing up anymore, as it does for the SF1 repo

I was never sure, why you could update branches in other repos. Maybe it has something to do with permissions in the foreign repo? Not sure if you ever could update one of our branches, I've seen it only for connorhu's branches.

@thePanz
Copy link
Member

thePanz commented Feb 11, 2024

Not sure why the "rebase branch" button is not showing up anymore, as it does for the SF1 repo

I was never sure, why you could update branches in other repos. Maybe it has something to do with permissions in the foreign repo? Not sure if you ever could update one of our branches, I've seen it only for connorhu's branches.

If you check "allow maintainer to push into this branch", it will allow it. It helps to have a quicker review process IMO. Yes, you can do much more than just rebase (as I did on another PR on the SF1 repo) and even push new commits and refactor code on other repos too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deprecations during test execution and turn deprecation helper back on

2 participants