Skip to content

Fixing test deprecations #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Fixing test deprecations #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ef8c2
Mockery 1.6.7 > Using atMost()->times(1) to avoid deprecation warning.
thirsch Feb 11, 2024
743b16e
PHP 8.2 > Creation of dynamic property Class::$property is deprecated
thirsch Feb 11, 2024
7207fe7
Re-Enabling deprecation warnings as errors for tests. Closes #8
thirsch Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,3 @@ jobs:
run: vendor/bin/simple-phpunit --verbose
env:
SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT: 1
SYMFONY_DEPRECATIONS_HELPER: weak
1 change: 1 addition & 0 deletions tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class Swift_Mime_AttachmentAcceptanceTest extends \PHPUnit\Framework\TestCase
private $cache;
private $headers;
private $emailValidator;
private $idGenerator;

protected function setUp()
{
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class Swift_Mime_EmbeddedFileAcceptanceTest extends \PHPUnit\Framework\TestCase
private $cache;
private $headers;
private $emailValidator;
private $idGenerator;

protected function setUp()
{
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class Swift_Mime_MimePartAcceptanceTest extends \PHPUnit\Framework\TestCase
private $cache;
private $headers;
private $emailValidator;
private $idGenerator;

protected function setUp()
{
Expand Down
6 changes: 4 additions & 2 deletions tests/unit/Swift/CharacterStream/ArrayCharacterStreamTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ public function testByteStreamCanBeImportingUsesValidator()
$stream = new Swift_CharacterStream_ArrayCharacterStream($factory, 'utf-8');

$os->shouldReceive('setReadPointer')
->between(0, 1)
->atMost()
->times(1)
->with(0);
$os->shouldReceive('read')->once()->andReturn(pack('C*', 0xD0));
$os->shouldReceive('read')->once()->andReturn(pack('C*', 0x94));
Expand Down Expand Up @@ -284,7 +285,8 @@ public function testImportingStreamProducesCorrectCharArray()
$stream = new Swift_CharacterStream_ArrayCharacterStream($factory, 'utf-8');

$os->shouldReceive('setReadPointer')
->between(0, 1)
->atMost()
->times(1)
->with(0);
$os->shouldReceive('read')->once()->andReturn(pack('C*', 0xD0));
$os->shouldReceive('read')->once()->andReturn(pack('C*', 0x94));
Expand Down