Unify RepeatDirection to use DataListEnum for simplified enum binding#326
Merged
csharpfritz merged 3 commits intodevfrom Jan 31, 2026
Merged
Unify RepeatDirection to use DataListEnum for simplified enum binding#326csharpfritz merged 3 commits intodevfrom
csharpfritz merged 3 commits intodevfrom
Conversation
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix attribute value conflicts with enums
Unify RepeatDirection to use DataListEnum for simplified enum binding
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RepeatDirectionwas implemented as a standard enum whileGridLinesused theDataListEnumclass hierarchy pattern. Both types haveHorizontalandVerticalvalues in the same namespace, causing ambiguity that forced verbose qualified syntax:This inconsistency created friction for Web Forms migration and deviated from the simpler markup patterns used elsewhere.
Changes
Unified parameter types
RadioButtonList.RepeatDirectionnow usesDataListEnum(matchingDataListandCheckBoxList)RepeatDirectionRemoved duplicate enum
RepeatDirectionclass hierarchy fromEnums/RepeatDirection.csDataListEnumremains, serving both GridLines and RepeatDirectionUpdated comparison logic
is VerticalRepeatDirectionto== DataListEnum.VerticalResult
Clean, unqualified syntax now works across all components:
Screenshots
RadioButtonList with horizontal and vertical layouts using simplified syntax:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.