feat: Milestone 7 Control Depth & Navigation Overhaul#343
Merged
csharpfritz merged 38 commits intoFritzAndFriends:devfrom Feb 24, 2026
Merged
feat: Milestone 7 Control Depth & Navigation Overhaul#343csharpfritz merged 38 commits intoFritzAndFriends:devfrom
csharpfritz merged 38 commits intoFritzAndFriends:devfrom
Conversation
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
…ends#333) - Create CalendarSelectionMode enum (None, Day, DayWeek, DayWeekMonth) - Refactor Calendar.SelectionMode from string to CalendarSelectionMode enum - Remove .GetAwaiter().GetResult() blocking call in CreateDayRenderArgs - Add Caption, CaptionAlign, UseAccessibleHeader properties - Update tests and samples to use enum values
- Calendar: date selection, selection modes, styling, day/title formats, events - FileUpload: basic upload, file type filtering, multiple files, disabled, styled - ImageMap: navigate/postback/mixed hot spot modes, rectangle/circle/polygon shapes - Updated NavMenu and ComponentList with links to all three new components
…ents into dev # Conflicts: # docs/EditorControls/FileUpload.md
…Friends#338 merge The FileUpload PR (FritzAndFriends#338) inadvertently reverted Sprint 1 gate review entries from agent histories (beast, cyclops, forge, jubilee, rogue) and downgraded the FileUpload InputFile decision in decisions.md. Restored from commit f85aa42 (docs(ai-team): Sprint 1 gate review results).
Creates .agent.md files for all 6 team agents (Beast, Cyclops, Forge, Jubilee, Rogue, Scribe) so they appear in GitHub Copilot's agent picker. Content sourced from existing .ai-team/agents/*/charter.md files.
Squad is the single Copilot agent that delegates to the specialized agents defined in .ai-team/agents/. Individual agent files were incorrectly created the correct pattern is one coordinator agent (squad.agent.md) that routes work to Forge, Cyclops, Beast, Jubilee, Rogue, and Scribe based on task type.
Session: 2026-02-10-sprint2-complete Requested by: Jeffrey T. Fritz Changes: - Logged Sprint 2 session (4 components shipped with docs, samples, tests) - Merged Sprint 2 design review decision from inbox - Removed duplicate FileUpload InputFile decision from inbox (already consolidated) - Appended Sprint 2 completion decision to decisions.md - Propagated cross-agent updates to all 5 agent histories
…ents into dev # Conflicts: # docs/UtilityFeatures/PageService.md # samples/AfterBlazorServerSide/Components/Pages/ControlSamples/Calendar/Index.razor
Session: 2026-02-11-sprint3-planning Requested by: Jeffrey T. Fritz Changes: - Logged session to .ai-team/log/2026-02-11-sprint3-planning.md - Merged 3 decisions from inbox into decisions.md - Updated status.md to reflect 48/53 components complete - Sprint 3 scope: DetailsView + PasswordRecovery - Propagated cross-agent updates to all agent history files
Session: 2026-02-12-sprint3-execution Requested by: Jeffrey T. Fritz Changes: - Logged Sprint 3 execution session - Merged 7 decisions from inbox into decisions.md - Sprint 3 gate review: DetailsView + PasswordRecovery APPROVED - Propagated cross-agent updates to Beast, Colossus, Cyclops, Rogue, Jubilee - status.md updated to 50/53 (94%)
Session: 2026-02-12-milestone4-planning Requested by: Jeffrey T. Fritz Changes: - Logged session to .ai-team/log/2026-02-12-milestone4-planning.md - Merged decisions from inbox (Chart.js evaluation, milestone plan, milestones directive) - Propagated milestone 4 updates to 5 agent history files
Session: 2026-02-12-milestone4-planning Requested by: Scribe (automatic) Changes: - Summarized Forge history.md (exceeded ~12KB threshold) - Preserved all team updates and key patterns
…sed) Closes the highest-impact feature gaps from the 53-control audit. P0 — Base class fixes (~180 gaps): AccessKey, ToolTip on all controls; DataBoundComponent inherits BaseStyledComponent; ValidatorDisplay + SetFocusOnError; Image/Label base class upgrades. P1 — Control improvements (~120 gaps): GridView paging/sorting/row editing; Calendar style sub-components + enums; FormView header/footer/empty data; HyperLink NavigateUrl rename; ValidationSummary HeaderText/ShowSummary/ValidationGroup. P2 — Nice-to-have (~45 gaps): DataTextFormatString + AppendDataBoundItems on BaseListControl; CausesValidation on CheckBox/RadioButton/TextBox; Menu Orientation; Label AssociatedControlID; Login controls base class upgrade. 168 files changed, +5,712 / -1,775 lines 1,065 tests passing, 0 failures
Add 10 display/layout properties to GridView matching Web Forms behavior: - ShowHeader, ShowFooter, ShowHeaderWhenEmpty for section visibility - Caption and CaptionAlign for table captions - EmptyDataTemplate (RenderFragment) taking precedence over EmptyDataText - GridLines enum rendering rules attribute on table - UseAccessibleHeader adding scope=col to th elements - CellPadding and CellSpacing for table spacing attributes Both GridLines and TableCaptionAlign enums already existed. Updated EmptyDataText test to use ShowHeaderWhenEmpty=true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add 8 style sub-components to GridView following the Calendar/DataList UiTableItemStyle + CascadingParameter pattern: - GridViewRowStyle, GridViewAlternatingRowStyle, GridViewHeaderStyle, GridViewFooterStyle, GridViewEmptyDataRowStyle, GridViewPagerStyle, GridViewEditRowStyle, GridViewSelectedRowStyle Each sub-component inherits UiTableItemStyle and uses CascadingParameter(Name="ParentGridView") to set the corresponding TableItemStyle property on the parent GridView via IGridViewStyleContainer. GridView.razor wraps style content in CascadingValue and applies styles as inline style attributes on the appropriate <tr> elements. GetRowStyle() resolves priority: Edit > Selected > Alternating > Row. Also includes GridView row selection support (SelectedIndex, AutoGenerateSelectButton, SelectRow) and fixes EmptyDataText test to use ShowHeaderWhenEmpty=true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…I-15) WI-11: TreeNodeStyle class with ChildNodesPadding, HorizontalPadding, ImageUrl, NodeSpacing, VerticalPadding. ITreeViewStyleContainer interface and 6 sub-components (NodeStyle, HoverNodeStyle, LeafNodeStyle, ParentNodeStyle, RootNodeStyle, SelectedNodeStyle). Style resolution: SelectedNodeStyle > type-specific > NodeStyle fallback. WI-13: SelectedNode, SelectedValue read-only properties. SelectedNodeChanged EventCallback. Click-to-select on TreeNode text. Deselects previous node. Keyboard (Enter/Space) triggers selection. WI-15: ExpandAll(), CollapseAll() public methods. FindNode(valuePath) navigates by PathSeparator-delimited path. ExpandDepth limits initial expansion. NodeIndent controls pixel indent. PathSeparator configurable. TreeNode exposes ValuePath, ChildNodes, SetExpanded(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- GridView: Add Selection, Style Sub-Components, and Display Properties sections - TreeView: Add Blazor syntax, Selection, Node Styles, Expand/Collapse sections - Menu: Add Selection/Events, Orientation, Style, Navigation sections with examples - Validators: Create ControlToValidate guide documenting dual-pattern support - mkdocs.yml: Add ControlToValidate page to Validation Controls nav Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GridView completion (~75%): - Selection: SelectedIndex, SelectedRow, SelectedValue, AutoGenerateSelectButton, SelectedIndexChanging/Changed - 8 style sub-components: RowStyle, AlternatingRowStyle, HeaderStyle, FooterStyle, EmptyDataRowStyle, PagerStyle, EditRowStyle, SelectedRowStyle - Display: ShowHeader, ShowFooter, Caption, CaptionAlign, EmptyDataTemplate, GridLines, UseAccessibleHeader, CellPadding, CellSpacing, ShowHeaderWhenEmpty - 24 bUnit tests covering all new features TreeView overhaul: - TreeNodeStyle system with 6 sub-components (Node, Hover, Leaf, Parent, Root, Selected) - Selection: SelectedNode, SelectedValue, SelectedNodeChanged - Expand/collapse: ExpandAll(), CollapseAll(), ExpandDepth, NodeIndent, PathSeparator, FindNode() - 25 bUnit tests Menu improvements: - Base class upgraded to BaseStyledComponent (BackColor, ForeColor, CssClass, etc.) - Selection: SelectedItem, SelectedValue, MenuItemClick event, MenuEventArgs - Core properties: MaximumDynamicDisplayLevels, Target, SkipLinkText, PathSeparator - MenuItem: Value, Target, ValuePath, EffectiveTarget - 16 bUnit tests DetailsView polish: - 10 style sub-components via IDetailsViewStyleContainer - Caption, CaptionAlign, PageCount - 15 bUnit tests FormView polish: - Events: ModeChanged, ItemCommand, ItemCreated, PageIndexChanging/Changed - 7 style sub-components via IFormViewStyleContainer - PagerTemplate, Caption, CaptionAlign - 17 bUnit tests Validator ControlToValidate: - String-based ControlToValidate for Web Forms migration (matches control ID) - Existing ForwardRef usage renamed to ControlRef - 5 bUnit tests Documentation: GridView, TreeView, Menu, ControlToValidate guide Sample pages: 9 new interactive demos Total: 1165 tests passing (76 new), 0 failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sample pages created: - ListView/CrudOperations.razor: Edit, delete, insert operations with EditItemTemplate and InsertItemTemplate - DataGrid/Styles.razor: Style sub-components (HeaderStyle, ItemStyle, AlternatingItemStyle, FooterStyle), Caption, GridLines, UseAccessibleHeader - Panel/BackImageUrl.razor: BackImageUrl property demo with placeholder images - LoginControls/OrientationSample.razor: Orientation (Vertical/Horizontal) and TextLayout (TextOnLeft/TextOnTop) demos Documentation updates: - ListView.md: Added CRUD operations section, events table, EditItemTemplate/InsertItemTemplate docs, migration example - DataGrid.md: Added style sub-components, Caption, GridLines, UseAccessibleHeader docs with migration example - Panel.md: Added BackImageUrl to features list and added usage example with HTML output - Login.md: Moved Orientation and TextLayout from NOT Supported to Supported, added layout docs and migration example Nav updates: - ListView Nav.razor: Added CRUD Operations link - DataGrid Nav.razor: Added Styles link Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ListView CRUD: 12 tests for HandleCommand routing (Edit, Cancel, Delete, Insert, Update), unknown commands, EditItemTemplate, EmptyItemTemplate, InsertItemTemplate positioning, and cancellation - DataGrid styles: 11 tests for 7 style sub-components, Caption/CaptionAlign, GridLines, UseAccessibleHeader, CellPadding/CellSpacing - DataGrid events: 3 tests for PageIndexChanged, SortCommand, SelectedIndex - Menu level styles: 7 tests for LevelMenuItemStyles, LevelSelectedStyles, LevelSubMenuStyles per-depth - Panel BackImageUrl: 3 tests for background-image rendering - Login Orientation: 5 tests for Vertical/Horizontal x TextOnLeft/TextOnTop layouts All 1206 tests pass (1165 existing + 41 new). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ListView CRUD: - 10 CRUD events: ItemCommand, ItemEditing, ItemCanceling, ItemDeleting/Deleted, ItemInserting/Inserted, ItemUpdating/Updated, ItemCreated - EditItemTemplate, InsertItemTemplate, EmptyItemTemplate, EditIndex, InsertItemPosition - HandleCommand routing for Edit/Cancel/Delete/Insert/Update commands - 9 event args classes + ListViewCancelMode enum DataGrid styles + events: - 7 style sub-components via IDataGridStyleContainer (AlternatingItemStyle, ItemStyle, HeaderStyle, FooterStyle, PagerStyle, SelectedItemStyle, EditItemStyle) - Caption, CaptionAlign, CellPadding, CellSpacing, GridLines, UseAccessibleHeader - PageIndexChanged, SortCommand, ItemCreated, ItemDataBound, SelectedIndexChanged events - GetRowStyle() with Edit > Selected > Alternating > Item priority Menu level styles: - LevelMenuItemStyles, LevelSelectedStyles, LevelSubMenuStyles (List<MenuLevelStyle>) - Per-depth-level styling that overrides static/dynamic base styles - MenuLevelStyle class with CSS properties Panel BackImageUrl: - BackImageUrl parameter renders as background-image in inline style Login/ChangePassword Orientation + TextLayout: - Orientation (Horizontal/Vertical) and TextLayout (TextOnLeft/TextOnTop) - LoginTextLayout enum - 4-layout matrix rendering (Orientation x TextLayout) - Fully-qualified enum references to avoid Razor name collision Integration tests: - 9 smoke tests + 9 interaction tests for all P0+P1 sample pages Tests: 41 new bUnit + 18 integration, 1206 total passing, 0 failures Samples: 4 new interactive demo pages Docs: Updated ListView, DataGrid, Panel, Login documentation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mplementation # Conflicts: # docs/DataControls/GridView.md # samples/AfterBlazorServerSide.Tests/ControlSampleTests.cs # samples/AfterBlazorServerSide.Tests/InteractiveComponentTests.cs # samples/AfterBlazorServerSide/Components/Pages/ControlSamples/GridView/Nav.razor # samples/AfterBlazorServerSide/Components/Pages/ControlSamples/Validations/RequiredFieldValidatorSample.razor # samples/AfterBlazorServerSide/Components/Pages/ControlSamples/Validations/ValidationSummarySample.razor # src/BlazorWebFormsComponents.Test/Validations/SetFocusOnErrorTests.razor # src/BlazorWebFormsComponents.Test/Validations/ValidationSummary/ValidationSummaryTests.razor # src/BlazorWebFormsComponents.Test/Validations/ValidatorDisplayTests.razor # src/BlazorWebFormsComponents/FormView.razor # src/BlazorWebFormsComponents/FormView.razor.cs # src/BlazorWebFormsComponents/GridView.razor # src/BlazorWebFormsComponents/GridView.razor.cs # src/BlazorWebFormsComponents/GridViewRow.razor # src/BlazorWebFormsComponents/GridViewRow.razor.cs # src/BlazorWebFormsComponents/LoginControls/ChangePassword.razor # src/BlazorWebFormsComponents/LoginControls/Login.razor # src/BlazorWebFormsComponents/Menu.razor # src/BlazorWebFormsComponents/TreeView.razor.cs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Vertical layout: username and password in separate rows | ||
| // Each label+input pair gets its own <tr> | ||
| var rows = cut.FindAll("table table tr"); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning test
| { | ||
| get | ||
| { | ||
| var separator = ParentMenu?.PathSeparator ?? '/'; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| [Parameter] | ||
| public TreeNodeSelectAction SelectAction { get; set; } | ||
|
|
||
| // TODO: Implement |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
|
|
||
| public override string ToString() | ||
| { | ||
| var builder = ((IStyle)this).ToStyle(); |
Check warning
Code scanning / CodeQL
Useless upcast Warning
Comment on lines
+73
to
+77
| foreach (var row in rows) | ||
| { | ||
| var style = row.GetAttribute("style"); | ||
| (style == null || !style.Contains("background-color")).ShouldBeTrue(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note test
Comment on lines
+130
to
+134
| foreach (var row in rows) | ||
| { | ||
| var style = row.GetAttribute("style"); | ||
| (style == null || !style.Contains("background-color")).ShouldBeTrue(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note test
Comment on lines
+292
to
+306
| if (args.CommandArgument is string pageArg) | ||
| { | ||
| newPosition = pageArg.ToLowerInvariant() switch | ||
| { | ||
| "next" => Math.Min(Position + 1, totalItems), | ||
| "prev" => Math.Max(Position - 1, 1), | ||
| "first" => 1, | ||
| "last" => totalItems, | ||
| _ => int.TryParse(pageArg, out var p) ? p : Position | ||
| }; | ||
| } | ||
| else | ||
| { | ||
| newPosition = Position; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+240
to
+243
| catch (Exception ex) | ||
| { | ||
| caughtException = ex; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
Comment on lines
+260
to
+263
| catch (Exception ex) | ||
| { | ||
| caughtException = ex; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
Comment on lines
+280
to
+283
| catch (Exception ex) | ||
| { | ||
| caughtException = ex; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
The client-side WebAssembly project includes all server-side sample pages via wildcard. InteractiveServer is a server-only render mode unavailable in the WebAssembly SDK, causing CS0103 build failure in CI. No other sample page uses @rendermode directives. Removing it makes this page consistent and fixes the AfterBlazorClientSide build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace bare text= locators with container-targeted selectors:
- GridView Selection: use p.Filter() for Selected index/Selection changes
- TreeView Selection: use div.Filter().Last for Selection count
- Menu Selection: use div.Filter().Last for Click count
- FormView Events: wait for specific button:has-text('Edit') selector
- FormView Styles: use td.Filter().First to avoid strict-mode violation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Menu/Selection.razor: add ID attributes to both Menu components (Menu JS interop requires an ID to find the DOM element; without it, Menu.js throws TypeError: Cannot read properties of null) - DetailsView_Styles test: use td.Filter() instead of text= locator to avoid strict mode violation (same pattern as FormView fix) - ControlSampleTests: fix misleading comment about Menu JS errors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The div.Filter(HasTextString).Last locator matches ALL ancestor divs containing the target text, making .Last unreliable in CI. Switch to direct DOM evaluation via EvaluateAsync to find the specific <strong> element and read its parent's text content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Menu JS interop (bwfc.Page.AddScriptElement + Menu.js) crashes the Blazor circuit in headless CI environments after click interaction, clearing the DOM content. Simplify to verify static rendering: - Menu items render correctly - Initial 'None' selection state is visible - Click count starts at 0 The MenuControl_Loads_AndRendersContent test already verifies the Menu Selection page loads without JS errors (with ID fix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 7: Control Depth & Navigation Overhaul (P0+P1)
Summary
130 files changed, +4,364/-156 lines, 1,165 tests passing (76 new), 0 failures.
GridView Completion (~75%)
TreeView Overhaul
Menu Improvements
DetailsView Polish
FormView Polish
Validator ControlToValidate (Migration-Blocking)
ControlToValidateparameter for Web Forms migration (matches control by ID)ForwardRefusage renamed toControlRef(breaking change, intentional)Tests & Documentation