fix: cross-platform line endings in analyzer code fix providers#488
Merged
csharpfritz merged 1 commit intodevfrom Mar 21, 2026
Merged
fix: cross-platform line endings in analyzer code fix providers#488csharpfritz merged 1 commit intodevfrom
csharpfritz merged 1 commit intodevfrom
Conversation
…rm CI Code fix providers for BWFC002, BWFC004, BWFC010, BWFC012 hardcoded \r\n in EndOfLine trivia, causing test failures on Linux CI runners where source files have \n line endings. Added SyntaxExtensions.DetectEndOfLine() helper that reads the first EndOfLineTrivia from the syntax tree, ensuring code fixes match the document's existing line ending style. Fixes failing tests in PR #487. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Code fix providers for BWFC002, BWFC004, BWFC010, BWFC012 hardcoded
\r\ninSyntaxFactory.EndOfLine()calls. This causes test failures on Linux CI runners where source files use\nline endings.Failing tests in PR #487:
ResponseRedirectAnalyzerTests.CodeFix_AddsNavigationManagerTodoCommentSessionUsageAnalyzerTests.CodeFix_SessionAccess_AddsTodoCommentSolution
Added
SyntaxExtensions.DetectEndOfLine()helper that reads the first EndOfLineTrivia from the syntax tree, ensuring code fixes match the document's existing line ending style.All 90 analyzer tests pass locally.