Skip to content

Mini Profiles - #33

Merged
multimokia merged 13 commits into
mainfrom
FROS-Mini-Profiles
Mar 19, 2023
Merged

Mini Profiles#33
multimokia merged 13 commits into
mainfrom
FROS-Mini-Profiles

Conversation

@multimokia

@multimokia multimokia commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

DO NOT MERGE UNTIL #32 IS MERGED

Mini Profiles

This PR introduces the beginning of profiles via mini-profiles on hover. Likewise, this PR allows nicknames to work for users

API Changes

  • Adds mini profiles which show up on hover
  • Adds support for nicknames on the frontend
  • Adds richer role integration to chat/profiles (chat message headers now use the highest role the user has that has a non-null color and mini-profiles list the roles a user has)
  • Cleaned up APIs for fetching messages w/ profiles using a postgres function, amended types in TS accordingly

Testing

  • Verify mini profiles with a small text field appear when you hover over a user's username in chat
  • Verify the mini profile accurately reflects a user's nickname as set in the server_users table for the server
  • Verify after switching channels, or WITHOUT switching channels, have another user send a message, then send a message from the user who's nickname was changed. Their message header (pfp + name) should now reflect the new settings

Known Issues

  • Hovering to view a miniprofile you've already seen before performs additional renders, investigation should be done to cut down on renders. UPDATE - Cause is react-tooltip, standalone this renders as expected. Switch this to a custom tooltip hover component when it's ready.

@multimokia multimokia added this to the WEEK 13 FINAL SUBMISSION milestone Mar 8, 2023
@multimokia
multimokia requested a review from Stan-l-e-y March 8, 2023 22:57
@multimokia
multimokia added this pull request to the merge queue Mar 19, 2023
@multimokia
multimokia merged commit 386f6c7 into main Mar 19, 2023
@multimokia
multimokia deleted the FROS-Mini-Profiles branch March 19, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants