Skip to content

Create channel UI - #49

Merged
Stan-l-e-y merged 15 commits into
mainfrom
FROS-Create-Server/Channel-UI
Mar 24, 2023
Merged

Create channel UI#49
Stan-l-e-y merged 15 commits into
mainfrom
FROS-Create-Server/Channel-UI

Conversation

@Stan-l-e-y

@Stan-l-e-y Stan-l-e-y commented Mar 24, 2023

Copy link
Copy Markdown
Member

Create Channel UI

This PR implements a user interface for creating channels in a given server

API Changes

  • adds a Realtime listener for insert on channels
  • adds a modal and form for creating a channel as well as a clickable tooltip that takes you to the modal
  • changes the way the server list is interacted with. To expand the server, the whole server component can be clicked. To close an expanded server, the user has to either click on the given server icon or on any other server component. To open the servers settings (for now the only option is create channel), expand a server and click on the 3 vertical dots to the right of the server component.

Any additional remarks:

  • If the User does not have adequate permissions, clicking on the server settings icon should not open the tooltip

Testing:

  • Test that you can expand and retract the server component properly, as mentioned in the API changes above
  • Test that, on a server where you have the right permissions, you can click on the server settings and that the create channel option appears
  • Test the inverse of the above (see additional remarks section)
  • Test that creating a channel with correct inputs is successful, as well as errors being displayed on a submission with incorrect inputs
  • Test that on successfully channel creation, the channel appears in the list of channels for that given server in real-time

@Stan-l-e-y
Stan-l-e-y requested a review from multimokia March 24, 2023 17:05
@github-advanced-security

Copy link
Copy Markdown

You have successfully added a new ESLint configuration .github/workflows/eslint.yml:eslint. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Comment thread types/client/channel.ts Outdated

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Stan-l-e-y
Stan-l-e-y added this pull request to the merge queue Mar 24, 2023
Merged via the queue into main with commit 410d39b Mar 24, 2023
@Stan-l-e-y
Stan-l-e-y deleted the FROS-Create-Server/Channel-UI branch March 24, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants