Skip to content

Port expanded About support copy to redesigned AboutPaneView#421

Merged
FuJacob merged 1 commit into
mainfrom
fix/about-pane-support-copy
May 30, 2026
Merged

Port expanded About support copy to redesigned AboutPaneView#421
FuJacob merged 1 commit into
mainfrom
fix/about-pane-support-copy

Conversation

@FuJacob

@FuJacob FuJacob commented May 30, 2026

Copy link
Copy Markdown
Owner

Summary

#411 expanded the support copy in About from one paragraph to two, but it edited Cotabby/UI/SettingsView.swift, which is the legacy settings root. The pane the redesigned Settings window actually shows is Cotabby/UI/Settings/Panes/AboutPaneView.swift (see its own file header: "Consolidates what used to live across three legacy sections..."). The redesign is gated by isRedesignEnabled in SettingsCoordinator and is on for users, so #411's copy never reached the UI.

This ports the same two-paragraph mission + ask into AboutPaneView.supportRow.

Validation

xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build
# ** BUILD SUCCEEDED **

swiftlint lint --quiet
# 0 issues

Visual check deferred to a screenshot on the running app; the diff is a 1-to-1 copy port from the legacy view's expanded label into a VStack(alignment: .leading, spacing: 8) inside the existing LabeledContent label, matching how the legacy view did it.

Linked issues

Refs #411.

Risk / rollout notes

  • Copy-only change inside one @ViewBuilder. No control flow, no state, no new dependencies.
  • Legacy SettingsView.swift is left untouched. It is still wired behind isRedesignEnabled in SettingsCoordinator, so deleting it is a separate decision.

Greptile Summary

This PR ports the expanded two-paragraph support copy (introduced in #411) from the legacy SettingsView.swift into the redesigned AboutPaneView.swift, which is the pane that actually renders for users when isRedesignEnabled is true.

  • Replaces the original single-paragraph label in supportRow with a VStack(alignment: .leading, spacing: 8) containing two Text views, matching the structure added to SettingsView.swift in Expand About support copy to two excerpts #411 character-for-character.
  • No logic, state, or dependency changes — copy-only edit inside a single @ViewBuilder property.

Confidence Score: 5/5

Safe to merge — copy-only change with no logic, state, or dependency impact.

The change is a character-for-character port of two Text strings and their VStack container from the legacy SettingsView.swift into AboutPaneView.swift. There is nothing to break: no control flow, no state mutations, no new imports, and the modifier chain is identical to the source. The legacy view is left untouched, so neither code path regresses.

No files require special attention.

Important Files Changed

Filename Overview
Cotabby/UI/Settings/Panes/AboutPaneView.swift Single-paragraph label in supportRow replaced with a two-paragraph VStack; copy and modifiers are a 1-to-1 match of the legacy view. No logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[SettingsCoordinator] -->|isRedesignEnabled = true| B[AboutPaneView]
    A -->|isRedesignEnabled = false| C[SettingsView - legacy]
    B --> D[supportRow]
    D --> E["VStack(alignment: .leading, spacing: 8)"]
    E --> F["Text: mission statement (paragraph 1)"]
    E --> G["Text: support ask (paragraph 2)"]
    D --> H["Link → ko-fi.com/cotabby"]
    C --> I["supportSection (unchanged)"]
    I --> J["Same two-paragraph copy (source of truth for #411)"]
Loading

Reviews (1): Last reviewed commit: "Port expanded About support copy to rede..." | Re-trigger Greptile

PR #411 expanded the support copy in the legacy SettingsView but did not
touch AboutPaneView, which is the pane the redesigned Settings window
actually shows (gated by isRedesignEnabled, on by default). Copy the same
two-paragraph mission + ask into the live pane so users see it.
@FuJacob FuJacob merged commit 419a9cf into main May 30, 2026
4 checks passed
@FuJacob FuJacob deleted the fix/about-pane-support-copy branch May 30, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant