Skip to content

Disable limited-tx-count feature when running benchmarks#3263

Merged
Dentosal merged 3 commits intomasterfrom
dento/test-helpers-limited-tx-count-fix
Apr 16, 2026
Merged

Disable limited-tx-count feature when running benchmarks#3263
Dentosal merged 3 commits intomasterfrom
dento/test-helpers-limited-tx-count-fix

Conversation

@Dentosal
Copy link
Copy Markdown
Member

@Dentosal Dentosal commented Apr 14, 2026

Description

The limited-tx-count feature in fuel-core-executor caps max_tx_count() at 1024. It was being activated in the benchmark binary via: benches → test-helpers → fuel-core-executor[limited-tx-count].

This caused blocks to be limited to 1024 user transactions, which causes benchmarks to fail.

The tests/Cargo.toml independently enables limited-tx-count in its own dev-deps, so the blocks.rs test that calls max_tx_count() remains correct. Tests crate enables it directly. The test-helpers dep on limited-tx-count was redundant and was only causing the transitive contamination into the benchmarks.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@Dentosal Dentosal self-assigned this Apr 14, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 14, 2026

PR Summary

Low Risk
Manifest-only change that removes an unintended feature flag; risk is limited to build/feature resolution differences in test/bench crates.

Overview
Removes the fuel-core-executor dependency with the limited-tx-count feature from tests/test-helpers/Cargo.toml, preventing that feature from being enabled transitively in downstream consumers (e.g., benchmarks).

This avoids accidentally capping block transaction counts during benchmarking while leaving any explicit test-only enabling of limited-tx-count to other crates.

Reviewed by Cursor Bugbot for commit 8ea9a0d. Bugbot is set up for automated code reviews on this repo. Configure here.

@Dentosal Dentosal added the no changelog Skip the CI check of the changelog modification label Apr 14, 2026
@Dentosal Dentosal marked this pull request as ready for review April 14, 2026 17:17
@Dentosal Dentosal enabled auto-merge (squash) April 16, 2026 20:20
@Dentosal Dentosal merged commit 945e83d into master Apr 16, 2026
40 checks passed
@Dentosal Dentosal deleted the dento/test-helpers-limited-tx-count-fix branch April 16, 2026 20:47
@xgreenx xgreenx mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Skip the CI check of the changelog modification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants