Disable limited-tx-count feature when running benchmarks#3263
Merged
Disable limited-tx-count feature when running benchmarks#3263
Conversation
PR SummaryLow Risk Overview This avoids accidentally capping block transaction counts during benchmarking while leaving any explicit test-only enabling of Reviewed by Cursor Bugbot for commit 8ea9a0d. Bugbot is set up for automated code reviews on this repo. Configure here. |
Voxelot
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
limited-tx-countfeature in fuel-core-executor caps max_tx_count() at 1024. It was being activated in the benchmark binary via:benches → test-helpers → fuel-core-executor[limited-tx-count].This caused blocks to be limited to 1024 user transactions, which causes benchmarks to fail.
The
tests/Cargo.tomlindependently enables limited-tx-count in its own dev-deps, so theblocks.rstest that callsmax_tx_count()remains correct. Tests crate enables it directly. Thetest-helpersdep onlimited-tx-countwas redundant and was only causing the transitive contamination into the benchmarks.Checklist
Before requesting review