Migrate dv-mod-profiles into this project - #12
Conversation
| ``` | ||
|
|
||
| The two are deliberately kept in separate solutions. `DVModProfiles` | ||
| and compiles against Derail Valley's shipped assemblies, so it cannot be built without |
There was a problem hiding this comment.
| and compiles against Derail Valley's shipped assemblies, so it cannot be built without | |
| compiles against Derail Valley's shipped assemblies, so it cannot be built without |
seems there was a leftover "and"
| } | ||
| catch | ||
| { | ||
| // Property getter threw, skip it |
There was a problem hiding this comment.
Why not at least debug logging here?
There was a problem hiding this comment.
Not a bad idea. I was pretty confident it would never happen but it doesn't hurt.
There was a problem hiding this comment.
When we merge this, this should lead to this repo but this can be changed afterwards too with a quick commit
| "Author": "SharkBaitDLS", | ||
| "EntryMethod": "DVModProfiles.Main.Load", | ||
| "ManagerVersion": "0.27.2", | ||
| "Repository": "https://raw.githubusercontent.com/SharkBaitDLS/DVModManager/beta/DVModProfiles/repository.json" |
There was a problem hiding this comment.
Here the same as for the repo.json
There was a problem hiding this comment.
I can fix these up real quick
|
I would also add you here as a developer so that you can code directly in this repo, if you want |
That would be great! |
2 participants
I pulled this in via a subtree so that the original commit history is retained for the WIP work that I initially did on this. Ideally this would be rebased/merged to retain that history. Since this needs a DV installation on the GitHub runner I deliberately kept it as a separate solution and out of the CI jobs for now. I have a self-hosted runner I can bring along that can build this if we want to get CI set up.