Honor the DFlash draft load config - #134
Closed
FujitsuPolycom wants to merge 1 commit into
Closed
Conversation
Patch the exact vLLM 0b67266 DFlash loader so get_model receives SpeculativeConfig.draft_load_config. An explicit draft LoadConfig can select safetensors while the target retains global fastsafetensors; None preserves the target LoadConfig fallback. Bind the preimage, patch, and postimage in the source-context receipt, image labels, composed verifier, profile requirements, and GPU-free semantic tests. Source commits, cache identity, and SparkCache namespace are unchanged. Validation: 42 focused tests passed; end-to-end context preparation and re-verification, Ruff, JSON, Python, Bash, and diff checks passed. The maintained suite retains one unrelated base README failure after 1,935 passes and 9 skips.
This was referenced Aug 30, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resulting behavior
The composed vLLM
0b67266a0f37d6146a8403fb8482403c62f412d5runtime passesSpeculativeConfig.draft_load_configinto the DFlashget_model()call. A profile can therefore keep global target loading on fastsafetensors while loading the external BF16 DFlash2 checkpoint with standard safetensors.The exact configuration shape is:
draft_load_configremains optional. When it is absent ornull, vLLM's existingget_model(load_config or vllm_config.load_config)rule retains the global target loader for the draft.Exact source contract
0b67266a0f37d6146a8403fb8482403c62f412d5ba9484ccb33aa56e90ff2f447f15ca9b9da97639vllm/v1/worker/gpu/spec_decode/dflash/utils.py2301c8199b73ed893dfbd3ae14ad125816f100b2d2ed034215b1f2d9aa2c23c539b567013ee7aed79f63200ed460129587933dc77fb430decdf19f78178de27998acbae2b3bb4482d83f9637c163ce7c92707ccdf6561b7e431f23337f151cf4The source preparer applies and reverses the patch against the immutable vLLM checkout to prove both byte boundaries. The prepared-context receipt, image labels, composed verifier, and profile label requirements bind the patch and postimage. GPU-free AST checks reject a DFlash loader that ignores
draft_load_configand reject a model-loader implementation that loses theNonefallback.Compatibility
This draft was created from exact SparkRing #131 commit
a7e5a70af1b7cb329651712a449c60f54b1d0ae5. The #131 branch later added unrelated README commit56b3a8f77d5b35a63bb97c213a73d34e5c178db6; that commit is deliberately not folded into this exact-base branch.No vLLM, B12X, SparkCache, NCCL, model, or image source commit changed. Existing MTP profile identity fields and SparkCache cache identity are unchanged. Cache namespace impact: none.
No image was built or published. No service or serving host was contacted or changed.
Validation