fix(main window): wire Instrument Precision and Tissue Analysis buttons to their own handlers - #1
Merged
Conversation
…utton9 handler; Instrument Precision was unreachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both the "Set Instrument Precision Values" (Button9) and "Tissue Analysis"
(Button21) buttons opened the Tissue Analysis window since v1.99 — a
copy-paste left behind when that feature was added (f9bc066). The Instrument
Precision dialogue (Form7) became unreachable from the UI.
This change resolves the open issue in the (un)main(tained) repo.
Changes
add new Button21Click (declared in TForm1) for the Tissue Analysis window.
Testing
Built with Fulhack/hydrobuddy-builder (lazbuild 3.2.2); verified both buttons now open their intended dialogues.