Skip to content

fix: use white-background favicon#199

Open
LeoninCS wants to merge 2 commits into
FullAgent:mainfrom
LeoninCS:main
Open

fix: use white-background favicon#199
LeoninCS wants to merge 2 commits into
FullAgent:mainfrom
LeoninCS:main

Conversation

@LeoninCS

@LeoninCS LeoninCS commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • Replace the dark gradient favicon with a white-background version
  • Use the Fulling Ink color for the logo while preserving the official mark geometry
  • Keep the logo centered with consistent safe-area padding
  • Synchronize the App Router icon and public fallback favicon

Testing

  • Validated both SVG files with xmllint
  • Verified the favicon at 16×16 and 32×32 sizes
  • Confirmed there is no clipping or distortion
  • Confirmed /icon.svg serves the updated favicon locally

Closes #190

Copilot AI review requested due to automatic review settings July 17, 2026 15:23
Copilot AI reviewed Jul 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Che-Zhu
Che-Zhu requested changes Jul 18, 2026
View reviewed changes

@Che-Zhu Che-Zhu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update both favicon SVGs to use the canonical Fulling Ink color #303055. The repository executable token and design documentation define Fulling Ink as #303055, while the current #1A1A2E value makes the favicon inconsistent with the documented brand system. If the darker value is intentional, please introduce and document a separate logo-mark color token instead.

Comment thread app/icon.svg Outdated
<rect width="78" height="78" fill="#FFFFFF"/>
<path
d="M49.5415 61.9998H28.4575V55.2917H49.5415V61.9998ZM27.4995 57.2087H20.7915V50.4998H27.4995V57.2087ZM57.2085 57.2087H50.4995V50.4998H57.2085V57.2087ZM22.7085 49.5417H15.9995V28.4578H22.7085V49.5417ZM62.0005 49.5417H55.2915L55.2925 28.4587H62.0005V49.5417ZM27.4995 27.4998H20.7915V20.7908H27.5005L27.4995 27.4998ZM57.2085 27.4998H50.4995V20.7908H57.2085V27.4998ZM49.5415 22.7078L28.4575 22.7087V15.9998H49.5415V22.7078Z"
fill="#1A1A2E"

@Che-Zhu Che-Zhu Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the canonical Fulling Ink value here: fill="#303055". #1A1A2E is not the documented --color-fulling-ink value; please make the same update in public/favicon.svg.

Comment thread public/favicon.svg Outdated
<rect width="78" height="78" fill="#FFFFFF"/>
<path
d="M49.5415 61.9998H28.4575V55.2917H49.5415V61.9998ZM27.4995 57.2087H20.7915V50.4998H27.4995V57.2087ZM57.2085 57.2087H50.4995V50.4998H57.2085V57.2087ZM22.7085 49.5417H15.9995V28.4578H22.7085V49.5417ZM62.0005 49.5417H55.2915L55.2925 28.4587H62.0005V49.5417ZM27.4995 27.4998H20.7915V20.7908H27.5005L27.4995 27.4998ZM57.2085 27.4998H50.4995V20.7908H57.2085V27.4998ZM49.5415 22.7078L28.4575 22.7087V15.9998H49.5415V22.7078Z"
fill="#1A1A2E"

@Che-Zhu Che-Zhu Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fill="#303055" here as well so the public fallback favicon stays synchronized with the App Router icon and the documented Fulling Ink token.

@LeoninCS LeoninCS Jul 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review, I have changed it, please check it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@Che-Zhu Che-Zhu Che-Zhu requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide a white-background version of the Fulling logo for the favicon

3 participants

@LeoninCS @Che-Zhu