fix(package.json, babel.config.js and yarn.lock): update our list of …#21
Merged
fix(package.json, babel.config.js and yarn.lock): update our list of …#21
Conversation
…supported browsers Update our list of supported browsers so that babel doesn't include so many core-js modules and the total size of the script is smaller.
charle692
commented
Aug 1, 2023
| "not android <= 5.0", | ||
| "not and_uc <= 100", | ||
| "not and_qq <= 100" | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
This list reflects what we use in the hw-admin side. My thoughts were that keeping the 2 aligned is probably a good idea as hw-admin wouldn't work in the iframe regardless if we supported older browsers in fs-js.
charle692
commented
Aug 1, 2023
| integrity sha512-pkpCg7dmI/a7WcqM2yfdOiT4Xx5tzyoHAXWsX5/HxZ3TemwDZs0QXdqbE0UPLPVy/7BeK7693YfzfRYfu1YVpg== | ||
| version "1.0.30001518" | ||
| resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001518.tgz" | ||
| integrity sha512-rup09/e3I0BKjncL+FesTayKtPrdwKhUufQFd3riFw1hHg8JmIFoInYfB102cFcY/pPgGmdyl/iy+jgiDi2vdA== |
Contributor
Author
There was a problem hiding this comment.
Locally I used npx browserslist to determine what list of browsers we "support" I noticed that the list of browsers though had outdated versions. There was an error in the output saying we should update this dependency so I did that and finally got the updated list of versions.
josejrdelapaz
approved these changes
Aug 1, 2023
benaiahbarango
approved these changes
Aug 2, 2023
Collaborator
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…supported browsers
Update our list of supported browsers so that babel doesn't include so many core-js modules and the total size of the script is smaller.