Skip to content

fix(package.json, babel.config.js and yarn.lock): update our list of … #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charle692 merged 1 commit into from
Aug 2, 2023
Merged

fix(package.json, babel.config.js and yarn.lock): update our list of … #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ module.exports = function (api) {
{
useBuiltIns: "usage",
corejs: "3.32",
targets: ["last 2 versions", "not dead", "not < 2%", "ie >= 11"], //https://browserl.ist/?q=last+2+versions%2C+not+dead%2C+%3E+0.2%25%2C+ie+%3E%3D11
},
],
["@babel/preset-typescript"],
Expand Down
15 changes: 15 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,21 @@
"regenerator-runtime": "^0.13.5",
"uuid": "^8.3.0"
},
"browserslist": [
"defaults",
"last 1 version",
"> 0.2%",
"not dead",
"not IE > 0",
"ios_saf >= 10.3",
"safari >= 10.1",
"not op_mini all",
"not baidu <= 100",
"not kaiOS <= 100",
"not android <= 5.0",
"not and_uc <= 100",
"not and_qq <= 100"
],
Copy link
Copy Markdown
Contributor Author

@charle692 charle692 Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list reflects what we use in the hw-admin side. My thoughts were that keeping the 2 aligned is probably a good idea as hw-admin wouldn't work in the iframe regardless if we supported older browsers in fs-js.

Copy link
Copy Markdown
Contributor

@josejrdelapaz josejrdelapaz Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

"config": {
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2487,9 +2487,9 @@ camelcase@^6.0.0:
integrity sha512-8KMDF1Vz2gzOq54ONPJS65IvTUaB1cHJ2DMM7MbPmLZljDH1qpzzLsWdiN9pHh6qvkRVDTi/07+eNGch/oLU4w==

caniuse-lite@^1.0.30001093:
version "1.0.30001104"
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001104.tgz#4e3d5b3b1dd3c3529f10cb7f519c62ba3e579f5d"
integrity sha512-pkpCg7dmI/a7WcqM2yfdOiT4Xx5tzyoHAXWsX5/HxZ3TemwDZs0QXdqbE0UPLPVy/7BeK7693YfzfRYfu1YVpg==
version "1.0.30001518"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001518.tgz"
integrity sha512-rup09/e3I0BKjncL+FesTayKtPrdwKhUufQFd3riFw1hHg8JmIFoInYfB102cFcY/pPgGmdyl/iy+jgiDi2vdA==
Copy link
Copy Markdown
Contributor Author

@charle692 charle692 Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally I used npx browserslist to determine what list of browsers we "support" I noticed that the list of browsers though had outdated versions. There was an error in the output saying we should update this dependency so I did that and finally got the updated list of versions.


capture-exit@^2.0.0:
version "2.0.0"
Expand Down