fix: use safe YAML loader for configs#312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch config parsing from
yaml.Loadertoyaml.SafeLoaderso modelconfig.yamlfiles are parsed as data only.This addresses the unsafe deserialization path reported in #311. A crafted YAML file using Python object tags is now rejected by PyYAML instead of being constructed at load time.
Verification run on
ind-gpu8:python3 -m py_compile utils/infer_utils.pygit diff --checkread_yamlsmoke test with a normal config and a!!python/object/applypayload, confirming the latter raisesConstructorError